From 1d9c431604cdc87b482d15134913747616111ddb Mon Sep 17 00:00:00 2001 From: Jeff Pinner Date: Sun, 4 May 2014 13:17:30 -0700 Subject: [PATCH] SPDY: remove unused code in SpdyHeaderBlockRawEncoder --- .../codec/spdy/SpdyHeaderBlockRawEncoder.java | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaderBlockRawEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaderBlockRawEncoder.java index bf0ed50257..923cbe94ec 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaderBlockRawEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaderBlockRawEncoder.java @@ -34,19 +34,11 @@ public class SpdyHeaderBlockRawEncoder extends SpdyHeaderBlockEncoder { } private void setLengthField(ByteBuf buffer, int writerIndex, int length) { - if (version < 3) { - buffer.setShort(writerIndex, length); - } else { - buffer.setInt(writerIndex, length); - } + buffer.setInt(writerIndex, length); } private void writeLengthField(ByteBuf buffer, int length) { - if (version < 3) { - buffer.writeShort(length); - } else { - buffer.writeInt(length); - } + buffer.writeInt(length); } @Override @@ -77,12 +69,7 @@ public class SpdyHeaderBlockRawEncoder extends SpdyHeaderBlockEncoder { valueLength += valueBytes.length + 1; } } - if (valueLength == 0) { - if (version < 3) { - throw new IllegalArgumentException( - "header value cannot be empty: " + name); - } - } else { + if (valueLength != 0) { valueLength --; } if (valueLength > SPDY_MAX_NV_LENGTH) {