andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make Bootstrap and ServerBootstrap fully overridable

Browse Source 
Related: #2034

Motivation:

Some users want to mock Bootstrap (or ServerBootstrap), and thus they
should not be final but be fully overridable and extensible.

Modifications:

Remove finals wherever possible

Result:

@daschl is happy.
This commit is contained in:
Trustin Lee 2014-10-17 16:16:13 +09:00
parent 0eb059bf58
commit 1e4bbe9839
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
View File

@ -392,7 +392,7 @@ public abstract class AbstractBootstrap<B extends AbstractBootstrap<B, C>, C ext
/** /**
* Return the configured {@link EventLoopGroup} or {@code null} if non is configured yet. * Return the configured {@link EventLoopGroup} or {@code null} if non is configured yet.
*/ */
public final EventLoopGroup group() { public EventLoopGroup group() {
return group; return group;
} }

2
transport/src/main/java/io/netty/bootstrap/Bootstrap.java
View File

@ -44,7 +44,7 @@ import java.util.Map.Entry;
* <p>The {@link #bind()} methods are useful in combination with connectionless transports such as datagram (UDP). * <p>The {@link #bind()} methods are useful in combination with connectionless transports such as datagram (UDP).
* For regular TCP connections, please use the provided {@link #connect()} methods.</p> * For regular TCP connections, please use the provided {@link #connect()} methods.</p>
*/ */
public final class Bootstrap extends AbstractBootstrap<Bootstrap, Channel> { public class Bootstrap extends AbstractBootstrap<Bootstrap, Channel> {
private static final InternalLogger logger = InternalLoggerFactory.getInstance(Bootstrap.class); private static final InternalLogger logger = InternalLoggerFactory.getInstance(Bootstrap.class);

2
transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java
View File

@ -42,7 +42,7 @@ import java.util.concurrent.TimeUnit;
* {@link Bootstrap} sub-class which allows easy bootstrap of {@link ServerChannel} * {@link Bootstrap} sub-class which allows easy bootstrap of {@link ServerChannel}
* *
*/ */
public final class ServerBootstrap extends AbstractBootstrap<ServerBootstrap, ServerChannel> { public class ServerBootstrap extends AbstractBootstrap<ServerBootstrap, ServerChannel> {
private static final InternalLogger logger = InternalLoggerFactory.getInstance(ServerBootstrap.class); private static final InternalLogger logger = InternalLoggerFactory.getInstance(ServerBootstrap.class);