andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Simplify CharSequenceValueConverter#convertToBoolean

Browse Source 
Motivation:
CharSequenceValueConverter#convertToBoolean has a few manual conditionals which can be removed if we use AsciiString.contentEqualsIgnoreCase. Also by comparing an AsciiString to a String we will incur conversions to char that can be avoided if we compare against AsciiString.

Modifications:
- Use AsciiString.contentEqualsIgnoreCase
- Compare against a AsciiString

Result:
Simplified CharSequenceValueConverter#convertToBoolean which favors AsciiString comparison.
This commit is contained in:
Scott Mitchell 2018-02-16 19:23:52 -08:00 committed by Norman Maurer
parent 15560530d4
commit 1e5fafe446
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec/src/main/java/io/netty/handler/codec/CharSequenceValueConverter.java
View File

@ -25,6 +25,7 @@ import java.util.Date;
*/
public class CharSequenceValueConverter implements ValueConverter<CharSequence> {
public static final CharSequenceValueConverter INSTANCE = new CharSequenceValueConverter();
private static final AsciiString TRUE_ASCII = new AsciiString("true");
@Override
public CharSequence convertObject(Object value) {
@ -66,14 +67,7 @@ public class CharSequenceValueConverter implements ValueConverter<CharSequence>
@Override
public boolean convertToBoolean(CharSequence value) {
if (value instanceof AsciiString) {
AsciiString asciiString = (AsciiString) value;
return asciiString.contentEqualsIgnoreCase("true");
}
if (value.length() != 4) {
return false;
}
return Boolean.parseBoolean(value.toString());
return AsciiString.contentEqualsIgnoreCase(value, TRUE_ASCII);
}
@Override