andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#3592] Flush when writing HttpChunkedInput

Browse Source 
Motivation:

We missed to flush the channel when using HttpChunkedInput (this is done when using SSL). This will result in a stale.

Modifications:

Replace ctx.write(...) with ctx.writeAndFlush(...)

Result:

Correctly working example.
This commit is contained in:
Norman Maurer 2015-04-08 11:29:59 +02:00
parent 3e42292d8b
commit 1e8a2e69db
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java
View File

@ -195,7 +195,7 @@ public class HttpStaticFileServerHandler extends SimpleChannelInboundHandler<Ful
lastContentFuture = ctx.writeAndFlush(LastHttpContent.EMPTY_LAST_CONTENT); lastContentFuture = ctx.writeAndFlush(LastHttpContent.EMPTY_LAST_CONTENT);
} else { } else {
sendFileFuture = sendFileFuture =
ctx.write(new HttpChunkedInput(new ChunkedFile(raf, 0, fileLength, 8192)), ctx.writeAndFlush(new HttpChunkedInput(new ChunkedFile(raf, 0, fileLength, 8192)),
ctx.newProgressivePromise()); ctx.newProgressivePromise());
// HttpChunkedInput will write the end marker (LastHttpContent) for us. // HttpChunkedInput will write the end marker (LastHttpContent) for us.
lastContentFuture = sendFileFuture; lastContentFuture = sendFileFuture;