andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing logging of ping acks in Http2OutboundFrameLogger

Browse Source 
Motivation:

The Http2OutboundFrameLogger logs all PING frames as not acks.

Modifications:

Changed the logger to correctly log PING acks.

Result:

PING acks are logged correctly.
This commit is contained in:
nmittler 2015-05-20 08:33:59 -07:00
parent 627831d658
commit 203ec13dd4
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2OutboundFrameLogger.java
View File

@ -89,7 +89,11 @@ public class Http2OutboundFrameLogger implements Http2FrameWriter {
@Override @Override
public ChannelFuture writePing(ChannelHandlerContext ctx, boolean ack, public ChannelFuture writePing(ChannelHandlerContext ctx, boolean ack,
ByteBuf data, ChannelPromise promise) { ByteBuf data, ChannelPromise promise) {
logger.logPing(OUTBOUND, data); if (ack) {
logger.logPingAck(OUTBOUND, data);
} else {
logger.logPing(OUTBOUND, data);
}
return writer.writePing(ctx, ack, data, promise); return writer.writePing(ctx, ack, data, promise);
} }