[#719] Handle http requests without an absolute path the right way when encoding them, which is adding / to it

codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java

@@ -24,13 +24,26 @@ import io.netty.util.CharsetUtil;
  * a {@link ByteBuf}.
  */
 public class HttpRequestEncoder extends HttpMessageEncoder {
+    private static final char SLASH = '/';
 
     @Override
     protected void encodeInitialLine(ByteBuf buf, HttpMessage message) throws Exception {
         HttpRequest request = (HttpRequest) message;
         buf.writeBytes(request.getMethod().toString().getBytes(CharsetUtil.US_ASCII));
         buf.writeByte(SP);
-        buf.writeBytes(request.getUri().getBytes(CharsetUtil.UTF_8));
+
+        // Add / as absolute path if no is present.
+        // See http://tools.ietf.org/html/rfc2616#section-5.1.2
+        String uri = request.getUri();
+        int start = uri.indexOf("://");
+        if (start != -1) {
+            int startIndex = start + 3;
+            if (uri.lastIndexOf(SLASH) <= startIndex) {
+                uri += SLASH;
+            }
+        }
+        buf.writeBytes(uri.getBytes("UTF-8"));
+
         buf.writeByte(SP);
         buf.writeBytes(request.getProtocolVersion().toString().getBytes(CharsetUtil.US_ASCII));
         buf.writeByte(CR);

codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java

@@ -0,0 +1,50 @@
+/*
+ * Copyright 2012 The Netty Project
+ *
+ * The Netty Project licenses this file to you under the Apache License,
+ * version 2.0 (the "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at:
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+package io.netty.handler.codec.http;
+
+import static org.junit.Assert.*;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+
+/**
+ */
+public class HttpRequestEncoderTest {
+
+    @Test
+    public void testUriWithoutPath() throws Exception {
+        HttpRequestEncoder encoder = new HttpRequestEncoder();
+        ByteBuf buffer = Unpooled.buffer(64);
+        encoder.encodeInitialLine(buffer, new DefaultHttpRequest(HttpVersion.HTTP_1_1,
+                HttpMethod.GET, "http://localhost"));
+        String req = buffer.toString(Charset.forName("US-ASCII"));
+        assertEquals("GET http://localhost/ HTTP/1.1\r\n", req);
+    }
+
+
+    @Test
+    public void testUriWithPath() throws Exception {
+        HttpRequestEncoder encoder = new HttpRequestEncoder();
+        ByteBuf buffer = Unpooled.buffer(64);
+        encoder.encodeInitialLine(buffer, new DefaultHttpRequest(HttpVersion.HTTP_1_1,
+                HttpMethod.GET, "http://localhost/"));
+        String req = buffer.toString(Charset.forName("US-ASCII"));
+        assertEquals("GET http://localhost/ HTTP/1.1\r\n", req);
+    }
+}