andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add test for Iterator.remove() on KObjectHashMap.values().iterator() (#8891)

Browse Source 
Motivation:

https://github.com/netty/netty/pull/8866 added support for calling Iterator.remove() but did not add a testcase.

Modifications:

Add testcase to ensure removal works.

Result:

Better test-coverage.
This commit is contained in:
Norman Maurer 2019-02-27 12:06:13 +01:00 committed by GitHub
parent e4d4775a10
commit 215b61e8e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
common/src/test/templates/io/netty/util/collection/KObjectHashMapTest.template
View File

@ -613,4 +613,34 @@ public class @K@ObjectHashMapTest {
}
assertTrue(map.isEmpty());
}
@Test
public void valuesIteratorRemove() {
Value v1 = new Value("v1");
Value v2 = new Value("v2");
Value v3 = new Value("v3");
map.put((@k@) 1, v1);
map.put((@k@) 2, v2);
map.put((@k@) 3, v3);
Iterator<Value> it = map.values().iterator();
assertSame(v1, it.next());
assertSame(v2, it.next());
it.remove();
assertSame(v3, it.next());
assertFalse(it.hasNext());
assertEquals(2, map.size());
assertSame(v1, map.get((@k@) 1));
assertNull(map.get((@k@) 2));
assertSame(v3, map.get((@k@) 3));
it = map.values().iterator();
assertSame(v1, it.next());
assertSame(v3, it.next());
assertFalse(it.hasNext());
}
}