diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpTransferEncoding.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpTransferEncoding.java index 507aa13808..5472014f3d 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpTransferEncoding.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpTransferEncoding.java @@ -56,7 +56,7 @@ public enum HttpTransferEncoding { private final boolean single; - private HttpTransferEncoding(boolean single) { + HttpTransferEncoding(boolean single) { this.single = single; } diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/CaseIgnoringComparator.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/CaseIgnoringComparator.java index ef86ef0de1..bcdcfdd91d 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/CaseIgnoringComparator.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/CaseIgnoringComparator.java @@ -25,7 +25,6 @@ public final class CaseIgnoringComparator implements Comparator, Seriali public static final CaseIgnoringComparator INSTANCE = new CaseIgnoringComparator(); private CaseIgnoringComparator() { - super(); } @Override diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyOrHttpChooser.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyOrHttpChooser.java index 56212f720a..c6d090f2fa 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyOrHttpChooser.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyOrHttpChooser.java @@ -39,7 +39,7 @@ import io.netty.handler.ssl.SslHandler; */ public abstract class SpdyOrHttpChooser extends ChannelHandlerAdapter implements ChannelInboundByteHandler { - public static enum SelectedProtocol { + public enum SelectedProtocol { SpdyVersion2, SpdyVersion3, HttpVersion1_1, diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketRequestBuilder.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketRequestBuilder.java index 0bec4da3b5..f24030c53d 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketRequestBuilder.java +++ b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketRequestBuilder.java @@ -76,17 +76,17 @@ public class WebSocketRequestBuilder { } public WebSocketRequestBuilder version13() { - this.version = WebSocketVersion.V13; + version = WebSocketVersion.V13; return this; } public WebSocketRequestBuilder version8() { - this.version = WebSocketVersion.V08; + version = WebSocketVersion.V08; return this; } public WebSocketRequestBuilder version00() { - this.version = null; + version = null; return this; } diff --git a/common/src/main/java/io/netty/monitor/MonitorName.java b/common/src/main/java/io/netty/monitor/MonitorName.java index ec8fb1520a..983dd5106b 100644 --- a/common/src/main/java/io/netty/monitor/MonitorName.java +++ b/common/src/main/java/io/netty/monitor/MonitorName.java @@ -139,7 +139,7 @@ public final class MonitorName { if (instance.equals(this.instance)) { return this; } - return new MonitorName(this.group, this.type, this.name, instance); + return new MonitorName(group, type, name, instance); } /** @@ -251,7 +251,7 @@ public final class MonitorName { */ @Override public String toString() { - return this.instance != null ? "Monitor(" + group + "/" + type + "/" + name + "/" + instance + ")" : "Monitor(" + return instance != null ? "Monitor(" + group + "/" + type + "/" + name + "/" + instance + ")" : "Monitor(" + group + "/" + type + "/" + name + ")"; } } diff --git a/common/src/main/java/io/netty/monitor/MonitorRegistries.java b/common/src/main/java/io/netty/monitor/MonitorRegistries.java index 863a838e96..5b48666242 100644 --- a/common/src/main/java/io/netty/monitor/MonitorRegistries.java +++ b/common/src/main/java/io/netty/monitor/MonitorRegistries.java @@ -127,12 +127,12 @@ public final class MonitorRegistries implements Iterable { @Override public boolean hasNext() { - return this.factories.hasNext(); + return factories.hasNext(); } @Override public MonitorRegistry next() { - return this.factories.next().newMonitorRegistry(); + return factories.next().newMonitorRegistry(); } @Override diff --git a/common/src/main/java/io/netty/monitor/spi/MonitorProvider.java b/common/src/main/java/io/netty/monitor/spi/MonitorProvider.java index a0983a5657..2b205fc2e3 100644 --- a/common/src/main/java/io/netty/monitor/spi/MonitorProvider.java +++ b/common/src/main/java/io/netty/monitor/spi/MonitorProvider.java @@ -63,7 +63,7 @@ public final class MonitorProvider implements Serializable, Comparable ValueMonitor registerValueMonitor(final MonitorName monitorName, final ValueMonitor valueMonitor) { - this.delegate.newGauge(Utils.toMetricName(monitorName), new Gauge() { + delegate.newGauge(Utils.toMetricName(monitorName), new Gauge() { @Override public T value() { return valueMonitor.currentValue(); @@ -108,7 +108,7 @@ public final class YammerMonitorRegistry implements MonitorRegistry { */ @Override public CounterMonitor newCounterMonitor(MonitorName monitorName) { - final Counter counter = this.delegate.newCounter(Utils.toMetricName(monitorName)); + final Counter counter = delegate.newCounter(Utils.toMetricName(monitorName)); return new YammerCounterMonitor(counter); } diff --git a/metrics-yammer/src/main/java/io/netty/monitor/yammer/YammerValueDistributionMonitor.java b/metrics-yammer/src/main/java/io/netty/monitor/yammer/YammerValueDistributionMonitor.java index f66ea8dac5..9219f39a61 100644 --- a/metrics-yammer/src/main/java/io/netty/monitor/yammer/YammerValueDistributionMonitor.java +++ b/metrics-yammer/src/main/java/io/netty/monitor/yammer/YammerValueDistributionMonitor.java @@ -44,7 +44,7 @@ final class YammerValueDistributionMonitor implements ValueDistributionMonitor { */ @Override public void reset() { - this.delegate.clear(); + delegate.clear(); } /** @@ -52,7 +52,7 @@ final class YammerValueDistributionMonitor implements ValueDistributionMonitor { */ @Override public void update(final long value) { - this.delegate.update(value); + delegate.update(value); } /** diff --git a/transport/src/main/java/com/sun/nio/sctp/UnsupportedOperatingSystemException.java b/transport/src/main/java/com/sun/nio/sctp/UnsupportedOperatingSystemException.java index 8cd99f1783..16fb81295f 100644 --- a/transport/src/main/java/com/sun/nio/sctp/UnsupportedOperatingSystemException.java +++ b/transport/src/main/java/com/sun/nio/sctp/UnsupportedOperatingSystemException.java @@ -24,7 +24,6 @@ public class UnsupportedOperatingSystemException extends RuntimeException { } public UnsupportedOperatingSystemException() { - super(); } public UnsupportedOperatingSystemException(String message) { diff --git a/transport/src/main/java/io/netty/channel/socket/SctpMessage.java b/transport/src/main/java/io/netty/channel/socket/SctpMessage.java index 139e34f447..1a921d2346 100644 --- a/transport/src/main/java/io/netty/channel/socket/SctpMessage.java +++ b/transport/src/main/java/io/netty/channel/socket/SctpMessage.java @@ -45,8 +45,8 @@ public final class SctpMessage { public SctpMessage(MessageInfo msgInfo, ByteBuf payloadBuffer) { this.msgInfo = msgInfo; - this.streamIdentifier = msgInfo.streamNumber(); - this.protocolIdentifier = msgInfo.payloadProtocolID(); + streamIdentifier = msgInfo.streamNumber(); + protocolIdentifier = msgInfo.payloadProtocolID(); this.payloadBuffer = payloadBuffer; } diff --git a/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java b/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java index c8c79066a4..1c216ece62 100755 --- a/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/aio/AioSocketChannel.java @@ -68,7 +68,7 @@ public class AioSocketChannel extends AbstractAioChannel implements SocketChanne private final Runnable readTask = new Runnable() { @Override public void run() { - AioSocketChannel.this.beginRead(); + beginRead(); } }; diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/socket/nio/NioEventLoop.java index 43b88085fc..9e95313290 100644 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioEventLoop.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioEventLoop.java @@ -132,7 +132,7 @@ public final class NioEventLoop extends SingleThreadEventLoop { // selector to the new one private Selector recreateSelector() { final Selector newSelector = openSelector(); - final Selector oldSelector = this.selector; + final Selector oldSelector = selector; // Register all channels to the new Selector. boolean success = false; @@ -166,7 +166,7 @@ public final class NioEventLoop extends SingleThreadEventLoop { } logger.info("Selector migration complete."); - return this.selector = newSelector; + return selector = newSelector; } @Override diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioSctpServerChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioSctpServerChannel.java index aaa87e670d..05c62f4cbb 100644 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioSctpServerChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioSctpServerChannel.java @@ -49,7 +49,7 @@ public class NioSctpServerChannel extends AbstractNioMessageChannel public NioSctpServerChannel() { super(null, null, newSocket(), SelectionKey.OP_ACCEPT); - config = new DefaultSctpServerChannelConfig(this.javaChannel()); + config = new DefaultSctpServerChannelConfig(javaChannel()); } @Override