andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix resource leak in InternalAttribute.setValue()

Browse Source
This commit is contained in:
Trustin Lee 2014-01-19 16:53:43 +09:00
parent 9b38e8778c
commit 2389c71e81
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-http/src/main/java/io/netty/handler/codec/http/multipart/InternalAttribute.java
View File

@ -31,7 +31,8 @@ final class InternalAttribute extends AbstractReferenceCounted implements Interf
private final List<ByteBuf> value = new ArrayList<ByteBuf>(); private final List<ByteBuf> value = new ArrayList<ByteBuf>();
private final Charset charset; private final Charset charset;
private int size; private int size;
public InternalAttribute(Charset charset) {
InternalAttribute(Charset charset) {
this.charset = charset; this.charset = charset;
} }
@ -66,6 +67,7 @@ final class InternalAttribute extends AbstractReferenceCounted implements Interf
ByteBuf old = this.value.set(rank, buf); ByteBuf old = this.value.set(rank, buf);
if (old != null) { if (old != null) {
size -= old.readableBytes(); size -= old.readableBytes();
old.release();
} }
size += buf.readableBytes(); size += buf.readableBytes();
} }