andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

It seems like using buffer pool during read doesn't seem to help performance at all.

Browse Source
This commit is contained in:
Trustin Lee 2010-02-18 11:34:34 +00:00
parent e7c329cc4e
commit 263e1ed601
1 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java
View File

@ -314,22 +314,13 @@ class NioWorker implements Runnable {
ChannelBuffer buffer = ChannelBuffer buffer =
bufferFactory.getBuffer(predictor.nextReceiveBufferSize()); bufferFactory.getBuffer(predictor.nextReceiveBufferSize());
final ByteBuffer directBuffer;
final boolean fromPool = !buffer.isDirect();
if (fromPool) {
directBuffer = directBufferPool.acquire(buffer.writableBytes());
directBuffer.mark();
} else {
directBuffer = buffer.toByteBuffer();
}
int ret = 0; int ret = 0;
int readBytes = 0; int readBytes = 0;
boolean failure = true; boolean failure = true;
try { try {
while ((ret = ch.read(directBuffer)) > 0) { while ((ret = buffer.writeBytes(ch, buffer.writableBytes())) > 0) {
readBytes += ret; readBytes += ret;
if (!directBuffer.hasRemaining()) { if (!buffer.writable()) {
break; break;
} }
} }
@ -338,15 +329,6 @@ class NioWorker implements Runnable {
// Can happen, and does not need a user attention. // Can happen, and does not need a user attention.
} catch (Throwable t) { } catch (Throwable t) {
fireExceptionCaught(channel, t); fireExceptionCaught(channel, t);
} finally {
if (fromPool) {
directBuffer.limit(directBuffer.position());
directBuffer.reset();
buffer.writeBytes(directBuffer);
} else {
// no need to copy: directBuffer is just a view to buffer.
buffer.writerIndex(buffer.writerIndex() + readBytes);
}
} }
if (readBytes > 0) { if (readBytes > 0) {