andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Lazily construct contained DataOutputStream in ByteBufOutputStream (#10507)

Browse Source 
Motivation

This is used solely for the DataOutput#writeUTF8() method, which may
often not be used.

Modifications

Lazily construct the contained DataOutputStream in ByteBufOutputStream.

Result

Saves an allocation in some common cases
This commit is contained in:
Nick Hill 2020-08-28 00:22:58 -07:00 committed by Norman Maurer
parent d7c1407d4c
commit 26993b0d9c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
buffer/src/main/java/io/netty/buffer/ByteBufOutputStream.java
View File

@ -41,7 +41,7 @@ public class ByteBufOutputStream extends OutputStream implements DataOutput {
private final ByteBuf buffer; private final ByteBuf buffer;
private final int startIndex; private final int startIndex;
private final DataOutputStream utf8out = new DataOutputStream(this); private DataOutputStream utf8out; // lazily-instantiated
/** /**
* Creates a new stream which writes data to the specified {@code buffer}. * Creates a new stream which writes data to the specified {@code buffer}.
@ -133,7 +133,11 @@ public class ByteBufOutputStream extends OutputStream implements DataOutput {
@Override @Override
public void writeUTF(String s) throws IOException { public void writeUTF(String s) throws IOException {
utf8out.writeUTF(s); DataOutputStream out = utf8out;
if (out == null) {
utf8out = out = new DataOutputStream(this);
}
out.writeUTF(s);
} }
/** /**