From 270e0785fd1b62db5638af96c4253c6f2e13e8eb Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Thu, 5 Feb 2015 21:02:56 +0100 Subject: [PATCH] Log only on debug log level in OpenSslEngine Motivation: At the moment we log priming read and handshake errors via info log level and still throw a SSLException that contains the error. We should only log with debug level to generate less noise. Modifications: Change logging to debug level. Result: Less noise . --- .../src/main/java/io/netty/handler/ssl/OpenSslEngine.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java index d7f8c5af28..cc4f294577 100644 --- a/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java +++ b/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java @@ -575,8 +575,8 @@ public final class OpenSslEngine extends SSLEngine { long error = SSL.getLastErrorNumber(); if (OpenSsl.isError(error)) { String err = SSL.getErrorString(error); - if (logger.isInfoEnabled()) { - logger.info( + if (logger.isDebugEnabled()) { + logger.debug( "SSL_read failed: primingReadResult: " + lastPrimingReadResult + "; OpenSSL error: '" + err + '\''); } @@ -1167,8 +1167,8 @@ public final class OpenSslEngine extends SSLEngine { long error = SSL.getLastErrorNumber(); if (OpenSsl.isError(error)) { String err = SSL.getErrorString(error); - if (logger.isInfoEnabled()) { - logger.info( + if (logger.isDebugEnabled()) { + logger.debug( "SSL_do_handshake failed: OpenSSL error: '" + err + '\''); }