andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix #1075: DefaultChannelHandlerContext.fireChannelSuspended and fireInboundBufferUpdated do not work correctly if handlers with EventExecutor are added or removed from pipeline.

Browse Source
This commit is contained in:
Trustin Lee 2013-02-21 17:16:05 -08:00
parent 08e2914cef
commit 273948055a
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java
View File

@ -912,8 +912,15 @@ final class DefaultChannelHandlerContext extends DefaultAttributeMap implements
next.invokeInboundBufferUpdatedTask = task = new Runnable() { next.invokeInboundBufferUpdatedTask = task = new Runnable() {
@Override @Override
public void run() { public void run() {
if (!pipeline.isInboundShutdown()) { if (pipeline.isInboundShutdown()) {
return;
}
if (findContextInbound() == next) {
next.invokeInboundBufferUpdated(); next.invokeInboundBufferUpdated();
} else {
// Pipeline changed since the task was submitted; try again.
fireInboundBufferUpdated0();
} }
} }
}; };
@ -968,7 +975,12 @@ final class DefaultChannelHandlerContext extends DefaultAttributeMap implements
next.invokeChannelReadSuspendedTask = task = new Runnable() { next.invokeChannelReadSuspendedTask = task = new Runnable() {
@Override @Override
public void run() { public void run() {
if (findContextInbound() == next) {
next.invokeChannelReadSuspended(); next.invokeChannelReadSuspended();
} else {
// Pipeline changed since the task was submitted; try again.
fireChannelReadSuspended();
}
} }
}; };
} }