andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Issue #220 - Treat content as non-empty on 101 Web Socket upgrade response

Browse Source
This commit is contained in:
Trustin Lee 2012-03-09 11:07:26 +09:00
parent 92a907c4d7
commit 279d859c7e
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
codec-http/src/main/java/io/netty/handler/codec/http/HttpMessageDecoder.java
View File

@ -368,12 +368,17 @@ public abstract class HttpMessageDecoder extends ReplayingDecoder<HttpMessageDec
if (msg instanceof HttpResponse) {
HttpResponse res = (HttpResponse) msg;
int code = res.getStatus().getCode();
// also check for code of 101 as 101 == Response to a websockets upgrade in earlier websocket versions.
//
// See https://github.com/netty/netty/issues/222
if (code < 200 && code != 101) {
if (code < 200) {
// Old Web Socket upgrade response had 16-byte fixed length content.
// See https://github.com/netty/netty/issues/222
if (code == 101 &&
res.containsHeader(HttpHeaders.Names.SEC_WEBSOCKET_ORIGIN) &&
res.containsHeader(HttpHeaders.Names.SEC_WEBSOCKET_LOCATION)) {
return false;
}
return true;
}
switch (code) {
case 204: case 205: case 304:
return true;