From 28d4600aa6204456253ef2f41fca560e156a06df Mon Sep 17 00:00:00 2001 From: Riley Park Date: Wed, 26 May 2021 01:06:05 -0700 Subject: [PATCH] Migrate codec-xml tests to JUnit 5 (#11311) Motivation: JUnit 5 is more expressive, extensible, and composable in many ways, and it's better able to run tests in parallel. Modifications: Use JUnit5 in codec-smtp tests Result: Related to https://github.com/netty/netty/issues/10757 --- .../io/netty/handler/codec/xml/XmlDecoderTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/codec-xml/src/test/java/io/netty/handler/codec/xml/XmlDecoderTest.java b/codec-xml/src/test/java/io/netty/handler/codec/xml/XmlDecoderTest.java index d36924d073..154aed8056 100644 --- a/codec-xml/src/test/java/io/netty/handler/codec/xml/XmlDecoderTest.java +++ b/codec-xml/src/test/java/io/netty/handler/codec/xml/XmlDecoderTest.java @@ -18,9 +18,9 @@ package io.netty.handler.codec.xml; import io.netty.buffer.Unpooled; import io.netty.channel.embedded.EmbeddedChannel; import io.netty.util.CharsetUtil; -import org.junit.After; -import org.junit.Before; -import org.junit.Test; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; import static org.hamcrest.CoreMatchers.*; import static org.hamcrest.MatcherAssert.*; @@ -52,12 +52,12 @@ public class XmlDecoderTest { private EmbeddedChannel channel; - @Before + @BeforeEach public void setup() throws Exception { channel = new EmbeddedChannel(new XmlDecoder()); } - @After + @AfterEach public void teardown() throws Exception { channel.finish(); }