andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#3883] OpenSSL SSLSession returns incorrect peer principal

Browse Source 
Motivation:

According to the javadocs of SSLSession.getPeerPrincipal should be returning the identity of the peer, while we return the identity of the issuer.

Modifications:

Return the correct indentity.

Result:

Behavior match the documentation.
This commit is contained in:
Norman Maurer 2015-06-12 06:11:54 +02:00
parent 4a0d68c50b
commit 29ac2ae3c2
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
View File

@ -1446,7 +1446,7 @@ public final class OpenSslEngine extends SSLEngine {
if (peer == null || peer.length == 0) {
return null;
}
return principal(peer);
return ((java.security.cert.X509Certificate) peer[0]).getSubjectX500Principal();
}
@Override
@ -1455,11 +1455,7 @@ public final class OpenSslEngine extends SSLEngine {
if (local == null || local.length == 0) {
return null;
}
return principal(local);
}
private Principal principal(Certificate[] certs) {
return ((java.security.cert.X509Certificate) certs[0]).getIssuerX500Principal();
return ((java.security.cert.X509Certificate) local[0]).getIssuerX500Principal();
}
@Override