From 2b786116b5613b57375973d8b6984b9e53f28a4b Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Thu, 28 Jan 2010 03:27:28 +0000 Subject: [PATCH] No need to copy if bufferFactory created a direct buffer --- .../java/org/jboss/netty/channel/socket/nio/NioWorker.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java b/src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java index b3e887b8ce..8ef886c0e4 100644 --- a/src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java +++ b/src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java @@ -334,8 +334,6 @@ class NioWorker implements Runnable { break; } } - directBuffer.flip(); - buffer.writeBytes(directBuffer); failure = false; } catch (ClosedChannelException e) { // Can happen, and does not need a user attention. @@ -343,6 +341,8 @@ class NioWorker implements Runnable { fireExceptionCaught(channel, t); } finally { if (fromPool) { + directBuffer.flip(); + buffer.writeBytes(directBuffer); directBufferPool.release(directBuffer); } }