andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleanup example to use local variable. (#8976)

Browse Source 
Motivation:

We can just use a local variable in HttpUploadServerHandler and so make the example code a bit cleaner.

Modifications:

Use local variable.

Result:

Fixes https://github.com/netty/netty/issues/8892.
This commit is contained in:
Norman Maurer 2019-03-25 20:54:57 +01:00
parent 1736b0e6a8
commit 2c50de46bb
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
example/src/main/java/io/netty/example/http/upload/HttpUploadServerHandler.java
View File

@ -69,8 +69,6 @@ public class HttpUploadServerHandler extends SimpleChannelInboundHandler<HttpObj
private HttpRequest request; private HttpRequest request;
private boolean readingChunks;
private HttpData partialContent; private HttpData partialContent;
private final StringBuilder responseContent = new StringBuilder(); private final StringBuilder responseContent = new StringBuilder();
@ -162,13 +160,12 @@ public class HttpUploadServerHandler extends SimpleChannelInboundHandler<HttpObj
return; return;
} }
readingChunks = HttpUtil.isTransferEncodingChunked(request); boolean readingChunks = HttpUtil.isTransferEncodingChunked(request);
responseContent.append("Is Chunked: " + readingChunks + "\r\n"); responseContent.append("Is Chunked: " + readingChunks + "\r\n");
responseContent.append("IsMultipart: " + decoder.isMultipart() + "\r\n"); responseContent.append("IsMultipart: " + decoder.isMultipart() + "\r\n");
if (readingChunks) { if (readingChunks) {
// Chunk version // Chunk version
responseContent.append("Chunks: "); responseContent.append("Chunks: ");
readingChunks = true;
} }
} }
@ -194,7 +191,6 @@ public class HttpUploadServerHandler extends SimpleChannelInboundHandler<HttpObj
// example of reading only if at the end // example of reading only if at the end
if (chunk instanceof LastHttpContent) { if (chunk instanceof LastHttpContent) {
writeResponse(ctx.channel()); writeResponse(ctx.channel());
readingChunks = false;
reset(); reset();
} }