diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpCodecUtil.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpCodecUtil.java index a9021db7d8..f9c3778b23 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpCodecUtil.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpCodecUtil.java @@ -57,7 +57,7 @@ final class HttpCodecUtil { /** * Validates the specified header value * - * @param value The value being validated + * @param headerValue The value being validated */ static void validateHeaderValue(String headerValue) { //Check to see if the value is null diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java index 1b4e216b58..e7a2ec8837 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java @@ -24,7 +24,7 @@ import io.netty.handler.codec.MessageToMessageDecoder; /** * Decodes the content of the received {@link HttpRequest} and {@link HttpChunk}. * The original content is replaced with the new content decoded by the - * {@link DecoderEmbedder}, which is created by {@link #newContentDecoder(String)}. + * {@link EmbeddedByteChannel}, which is created by {@link #newContentDecoder(String)}. * Once decoding is finished, the value of the 'Content-Encoding' * header is set to the target content encoding, as returned by {@link #getTargetContentEncoding(String)}. * Also, the 'Content-Length' header is updated to the length of the @@ -127,11 +127,11 @@ public abstract class HttpContentDecoder extends MessageToMessageDecodercontentEncoding. * * @param contentEncoding the value of the {@code "Content-Encoding"} header - * @return a new {@link DecoderEmbedder} if the specified encoding is supported. + * @return a new {@link EmbeddedByteChannel} if the specified encoding is supported. * {@code null} otherwise (alternatively, you can throw an exception * to block unknown encoding). */ @@ -145,6 +145,7 @@ public abstract class HttpContentDecoder extends MessageToMessageDecoder'Content-Encoding' header * is set to the target content encoding, as returned by * {@link #beginEncode(HttpMessage, String)}. @@ -163,7 +163,7 @@ public abstract class HttpContentEncoder extends MessageToMessageCodec * triggers {@link HttpRequestDecoder} to generate 4 objects: *
    - *
  1. An {@link HttpRequest} whose {@link HttpMessage#isChunked() chunked} - * property is {@code true},
    2. + *
  2. An {@link HttpRequest} whose {@link HttpMessage#getTransferEncoding()} + * property is {@link HttpTransferEncoding#CHUNKED},
    3. *
  3. The first {@link HttpChunk} whose content is {@code 'abcdefghijklmnopqrstuvwxyz'},
    4. *
  4. The second {@link HttpChunk} whose content is {@code '1234567890abcdef'}, and
    5. *
  5. An {@link HttpChunkTrailer} which marks the end of the content.
    6. diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequest.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequest.java index c82c3ae5e4..6ed92931d5 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequest.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequest.java @@ -43,7 +43,7 @@ public interface HttpRequest extends HttpMessage { /** * Sets the {@link HttpMethod} of this {@link HttpRequest}. * - * @param The {@link HttpMethod} to set + * @param method The {@link HttpMethod} to set */ void setMethod(HttpMethod method); diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java index 134d30a970..5e94daeeee 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java @@ -24,6 +24,8 @@ import io.netty.util.CharsetUtil; */ public class CloseWebSocketFrame extends WebSocketFrame { + private static final byte[] EMTPY_REASON = new byte[0]; + /** * Creates a new empty close frame. */ @@ -73,7 +75,7 @@ public class CloseWebSocketFrame extends WebSocketFrame { setFinalFragment(finalFragment); setRsv(rsv); - byte[] reasonBytes = new byte[0]; + byte[] reasonBytes = EMTPY_REASON; if (reasonText != null) { reasonBytes = reasonText.getBytes(CharsetUtil.UTF_8); } diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpResponseStreamIdHandler.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpResponseStreamIdHandler.java index 2aeea40cdb..883f8a91d8 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpResponseStreamIdHandler.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpResponseStreamIdHandler.java @@ -24,7 +24,7 @@ import io.netty.handler.codec.http.HttpMessage; import io.netty.handler.codec.http.HttpResponse; /** - * {@link MessageToMessageCodec} that takes care of adding the right {@link SpdyHttpHeaders#Names#STREAM_ID} to the + * {@link MessageToMessageCodec} that takes care of adding the right {@link SpdyHttpHeaders.Names#STREAM_ID} to the * {@link HttpResponse} if one is not present. This makes it possible to just re-use plan handlers current used * for HTTP. */