andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make DnsNameResolverGroup non-final and overridable

Browse Source 
Motivation:

There's no way to override the default settings of the DnsNameResolvers
created by DnsNameResolverGroup because DnsNameResolverGroup is final.

Modifications:

- Make DnsNameResolverGroup non-final
- Add a new overridable protected method 'newResolver()' so that a user
  can override it to create an alternative DnsNameResolver instance or
  set the non-default properties

Result:

A user can configure the DnsNameResolver.
This commit is contained in:
Trustin Lee 2015-12-07 18:43:32 +09:00
parent a3bdd8c948
commit 2fefb2f79c
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverGroup.java
View File

@ -27,12 +27,12 @@ import io.netty.util.internal.StringUtil;
import java.net.InetSocketAddress;
import static io.netty.resolver.dns.DnsNameResolver.*;
import static io.netty.resolver.dns.DnsNameResolver.ANY_LOCAL_ADDR;
/**
* A {@link NameResolverGroup} of {@link DnsNameResolver}s.
*/
public final class DnsNameResolverGroup extends NameResolverGroup<InetSocketAddress> {
public class DnsNameResolverGroup extends NameResolverGroup<InetSocketAddress> {
private final ChannelFactory<? extends DatagramChannel> channelFactory;
private final InetSocketAddress localAddress;
@ -63,13 +63,25 @@ public final class DnsNameResolverGroup extends NameResolverGroup<InetSocketAddr
}
@Override
protected NameResolver<InetSocketAddress> newResolver(EventExecutor executor) throws Exception {
protected final NameResolver<InetSocketAddress> newResolver(EventExecutor executor) throws Exception {
if (!(executor instanceof EventLoop)) {
throw new IllegalStateException(
"unsupported executor type: " + StringUtil.simpleClassName(executor) +
" (expected: " + StringUtil.simpleClassName(EventLoop.class));
}
return new DnsNameResolver((EventLoop) executor, channelFactory, localAddress, nameServerAddresses);
return newResolver((EventLoop) executor, channelFactory, localAddress, nameServerAddresses);
}
/**
* Creates a new {@link DnsNameResolver}. Override this method to create an alternative {@link DnsNameResolver}
* implementation or override the default configuration.
*/
protected DnsNameResolver newResolver(
EventLoop eventLoop, ChannelFactory<? extends DatagramChannel> channelFactory,
InetSocketAddress localAddress, DnsServerAddresses nameServerAddresses) throws Exception {
return new DnsNameResolver(
eventLoop, channelFactory, localAddress, nameServerAddresses);
}
}