From 322fe8ec85d72271a5ac0ed3f0149c4ea1323168 Mon Sep 17 00:00:00 2001 From: Carl Mastrangelo Date: Fri, 23 Jun 2017 20:04:43 -0700 Subject: [PATCH] Exhaust non-exhaustive switch cases Motivation: ErrorProne warns about missing cases in switch statements that appear as an oversight. Modifcation: Add the last case to statement to ensure all cases are covered. Result: Able to enable Error Prone static analysis --- handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java index a3839bc496..3b03cd4525 100644 --- a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java +++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java @@ -244,6 +244,10 @@ public class JdkSslContext extends SslContext { case REQUIRE: engine.setNeedClientAuth(true); break; + case NONE: + break; // exhaustive cases + default: + throw new Error("Unknown auth " + clientAuth); } } return apn.wrapperFactory().wrapSslEngine(engine, apn, isServer());