diff --git a/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequest.java b/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequest.java index a243d3bd79..28e70ac3d0 100644 --- a/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequest.java +++ b/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequest.java @@ -28,6 +28,7 @@ import java.nio.charset.CharsetEncoder; */ public final class SocksAuthRequest extends SocksRequest { private static final CharsetEncoder asciiEncoder = CharsetUtil.getEncoder(CharsetUtil.US_ASCII); + private static final SubnegotiationVersion SUBNEGOTIATION_VERSION = SubnegotiationVersion.AUTH_PASSWORD; private final String username; private final String password; @@ -73,7 +74,7 @@ public final class SocksAuthRequest extends SocksRequest { @Override public void encodeAsByteBuf(ByteBuf byteBuf) { - byteBuf.writeByte(getProtocolVersion().getByteValue()); + byteBuf.writeByte(SUBNEGOTIATION_VERSION.getByteValue()); byteBuf.writeByte(username.length()); byteBuf.writeBytes(username.getBytes(CharsetUtil.US_ASCII)); byteBuf.writeByte(password.length()); diff --git a/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequestDecoder.java b/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequestDecoder.java index 79962f640e..3f4e9e8df7 100644 --- a/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequestDecoder.java +++ b/codec-socks/src/main/java/io/netty/codec/socks/SocksAuthRequestDecoder.java @@ -31,7 +31,7 @@ public class SocksAuthRequestDecoder extends ReplayingDecoder