andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix potential buffer leak in AbstractBinaryMemcacheDecoder

Browse Source 
If a connection is closed unexpectedly while
AbstractBinaryMemcacheDecoder decodes a message, the half-constructed
message's content might not be released.
This commit is contained in:
Trustin Lee 2014-06-24 16:22:53 +09:00
parent cde319dabd
commit 33b9bc02ed
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheDecoder.java
View File

@ -200,8 +200,8 @@ public abstract class AbstractBinaryMemcacheDecoder<M extends BinaryMemcacheMess
public void channelInactive(ChannelHandlerContext ctx) throws Exception { public void channelInactive(ChannelHandlerContext ctx) throws Exception {
super.channelInactive(ctx); super.channelInactive(ctx);
if (currentMessage != null && currentMessage.extras() != null) { if (currentMessage != null) {
currentMessage.extras().release(); currentMessage.release();
} }
resetDecoder(); resetDecoder();