From 3405aee2abf990d1f6078eb27da1b0035ab34769 Mon Sep 17 00:00:00 2001 From: JongYoonLim Date: Thu, 19 Mar 2015 14:25:19 +0900 Subject: [PATCH] Returns after encoding each message not do check following instance types Motivation: Current AbstractMemcacheObjectEncoder does unnecessary message type checking if the message is MemcacheMessage type. Modifications: Returns after encoding MemcacheMessage message. Result: Small performance improvement for this encoder. --- .../handler/codec/memcache/AbstractMemcacheObjectEncoder.java | 1 + 1 file changed, 1 insertion(+) diff --git a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java index 4248f81210..b209fcd110 100644 --- a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java +++ b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/AbstractMemcacheObjectEncoder.java @@ -45,6 +45,7 @@ public abstract class AbstractMemcacheObjectEncoder e @SuppressWarnings({ "unchecked", "CastConflictsWithInstanceof" }) final M m = (M) msg; out.add(encodeMessage(ctx, m)); + return; } if (msg instanceof MemcacheContent || msg instanceof ByteBuf || msg instanceof FileRegion) {