From 34d52fcbfe2a7e6017267101692e1e29f03896e5 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Fri, 14 Sep 2018 20:33:09 +0200 Subject: [PATCH] Implemented ExtendedOpenSslSession.getStatusResponses() so it not throws an UnsupportedOperationException. (#8290) Motivation: 6ed7c6c75d458047adc37470697f215e9d7436ea added support for ExtendedOpenSslSession but we did not override getStatusResponses(). This lead to test failures on java9. Modifications: Implement ExtendedOpenSslSession.getStatusResponses() so it just returns an empty list. Result: Test pass again on Java9. --- .../java/io/netty/handler/ssl/ExtendedOpenSslSession.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java b/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java index 041e99f2e2..87185db529 100644 --- a/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java +++ b/handler/src/main/java/io/netty/handler/ssl/ExtendedOpenSslSession.java @@ -24,6 +24,7 @@ import javax.net.ssl.SSLSessionContext; import javax.security.cert.X509Certificate; import java.security.Principal; import java.security.cert.Certificate; +import java.util.Collections; import java.util.List; /** @@ -51,6 +52,13 @@ abstract class ExtendedOpenSslSession extends ExtendedSSLSession implements Open @SuppressWarnings({ "unchecked", "rawtypes" }) public abstract List getRequestedServerNames(); + // Do not mark as override so we can compile on java8. + public List getStatusResponses() { + // Just return an empty list for now until we support it as otherwise we will fail in java9 + // because of their sun.security.ssl.X509TrustManagerImpl class. + return Collections.emptyList(); + } + @Override public void handshakeFinished() throws SSLException { wrapped.handshakeFinished();