From 34dfa7a2d8679b874ad624ecd735e448eda4f258 Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Tue, 18 Aug 2015 10:57:32 -0700 Subject: [PATCH] DefaultHttp2ConnectionEncoder private constructors on inner classes Motivation: DefaultHttp2ConnectionEncoder.FlowControlledHeaders and DefaultHttp2ConnectionEncoder.FlowControlledData have private constructors which may result in static factory methods being generated to construct instances of these classes. Modifications: - Make constructors public for these private classes Result: Accessor for inner class constructor more correct and no possibiliy of synthetic method generation. --- .../handler/codec/http2/DefaultHttp2ConnectionEncoder.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java index 37757c9d4a..d84e4c726e 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java @@ -315,10 +315,9 @@ public class DefaultHttp2ConnectionEncoder implements Http2ConnectionEncoder { *

*/ private final class FlowControlledData extends FlowControlledBase { - private final CoalescingBufferQueue queue; - private FlowControlledData(Http2Stream stream, ByteBuf buf, int padding, boolean endOfStream, + public FlowControlledData(Http2Stream stream, ByteBuf buf, int padding, boolean endOfStream, ChannelPromise promise) { super(stream, padding, endOfStream, promise); queue = new CoalescingBufferQueue(promise.channel()); @@ -384,7 +383,7 @@ public class DefaultHttp2ConnectionEncoder implements Http2ConnectionEncoder { private final short weight; private final boolean exclusive; - private FlowControlledHeaders(Http2Stream stream, Http2Headers headers, int streamDependency, short weight, + public FlowControlledHeaders(Http2Stream stream, Http2Headers headers, int streamDependency, short weight, boolean exclusive, int padding, boolean endOfStream, ChannelPromise promise) { super(stream, padding, endOfStream, promise); this.headers = headers;