From 38524ec3e29100520dd4004841e6e62d7c50ba3f Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 19 Nov 2018 12:13:05 +0100 Subject: [PATCH] Fix test that assumed detection of peer supported algs is not supported in BoringSSL. (#8573) Motivation: 0d2e38d5d6db6ed1abdf901230fa524c0f8db14c added supported for detection of peer supported algorithms but we missed to fix the testcase. Modifications: Fix test-case. Result: No more failing tests with BoringSSL. --- .../io/netty/handler/ssl/SniClientJava8TestUtil.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/handler/src/test/java/io/netty/handler/ssl/SniClientJava8TestUtil.java b/handler/src/test/java/io/netty/handler/ssl/SniClientJava8TestUtil.java index 26904c0117..4db7c7b73a 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SniClientJava8TestUtil.java +++ b/handler/src/test/java/io/netty/handler/ssl/SniClientJava8TestUtil.java @@ -64,7 +64,6 @@ import java.security.UnrecoverableKeyException; import java.security.cert.CertificateException; import java.security.cert.X509Certificate; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collections; import java.util.List; @@ -182,13 +181,7 @@ final class SniClientJava8TestUtil { if (clientSide) { Assert.assertEquals(0, extendedSSLSession.getPeerSupportedSignatureAlgorithms().length); } else { - if (session instanceof OpenSslSession && OpenSsl.isBoringSSL()) { - // BoringSSL does not support SSL_get_sigalgs(...) - // https://boringssl.googlesource.com/boringssl/+/ba16a1e405c617f4179bd780ad15522fb25b0a65%5E%21/ - Assert.assertEquals(0, extendedSSLSession.getPeerSupportedSignatureAlgorithms().length); - } else { - Assert.assertTrue(extendedSSLSession.getPeerSupportedSignatureAlgorithms().length > 0); - } + Assert.assertTrue(extendedSSLSession.getPeerSupportedSignatureAlgorithms().length >= 0); } } }