andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Motivation:

Browse Source 
Make the FileRegion comments about which transports are supported more accurate.
Also, eleminate any outstanding references to FileRegion.transfered as the method was renamed for spelling.

Modifications:

Class-level comment on FileRegion, can call renamed method.

Result:

More accurate documentation and less calls to deprecated methods.
This commit is contained in:
Jason Brown 2017-03-06 10:17:03 -08:00 committed by Scott Mitchell
parent 743d2d374c
commit 3861b7de2b
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
View File

@ -265,7 +265,7 @@ public class SocketFileRegionTest extends AbstractSocketTest {
@Override @Override
@Deprecated @Deprecated
public long transfered() { public long transfered() {
return region.transfered(); return region.transferred();
} }
@Override @Override

2
transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
View File

@ -399,7 +399,7 @@ public abstract class AbstractEpollStreamChannel extends AbstractEpollChannel im
} }
flushedAmount += localFlushedAmount; flushedAmount += localFlushedAmount;
if (region.transfered() >= regionCount) { if (region.transferred() >= regionCount) {
done = true; done = true;
break; break;
} }

2
transport/src/main/java/io/netty/channel/FileRegion.java
View File

@ -49,8 +49,6 @@ import java.nio.channels.WritableByteChannel;
* performance. For example, sending a large file doesn't work well in Windows. * performance. For example, sending a large file doesn't work well in Windows.
* *
* <h3>Not all transports support it</h3> * <h3>Not all transports support it</h3>
*
* Currently, the NIO transport is the only transport that supports {@link FileRegion}.
*/ */
public interface FileRegion extends ReferenceCounted { public interface FileRegion extends ReferenceCounted {