andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for NETTY-183 Client-side HTTP tunneling transport logs and swallows an exceptionCaught event.

Browse Source 
* HttpTunnelingClientSocketChannel.ServletChannelHandler does not log the caught exception anymore. The exception is propagated to the HttpTunnelingClientSocketChannel's pipeline.
* More comprehensive log message on the server side
This commit is contained in:
Trustin Lee 2009-06-24 18:12:00 +00:00
parent 8dd55b0368
commit 3a2350158d
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/jboss/netty/channel/socket/http/HttpTunnelingChannelHandler.java
View File

@ -134,7 +134,7 @@ class HttpTunnelingChannelHandler extends SimpleChannelUpstreamHandler {
@Override
public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent e) throws Exception {
logger.warn("Unexpected exception", e.getCause());
logger.warn("Unexpected exception while HTTP tunneling", e.getCause());
invalidateHttpSession();
e.getChannel().close();
}

4
src/main/java/org/jboss/netty/channel/socket/http/HttpTunnelingClientSocketChannel.java
View File

@ -278,7 +278,9 @@ class HttpTunnelingClientSocketChannel extends AbstractChannel
@Override
public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent e) throws Exception {
logger.warn("Unexpected exception", e.getCause());
fireExceptionCaught(
HttpTunnelingClientSocketChannel.this,
e.getCause());
channel.close();
}
}