andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* Simplified the SecurityManager implementation in DebugUtilTest

Browse Source 
* Added ThreadRenamingRunnableTest
This commit is contained in:
Trustin Lee 2008-08-25 06:05:21 +00:00
parent 4d55da5c7e
commit 3dbe973735
2 changed files with 101 additions and 142 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

142
src/test/java/org/jboss/netty/util/DebugUtilTest.java
View File

@ -24,8 +24,6 @@ package org.jboss.netty.util;
import static org.junit.Assert.*;
import java.io.FileDescriptor;
import java.net.InetAddress;
import java.security.Permission;
import org.junit.After;
@ -67,91 +65,6 @@ public class DebugUtilTest {
throw new SecurityException();
}
@Override
public void checkAccept(String host, int port) {
// Allow
}
@Override
public void checkAccess(Thread t) {
// Allow
}
@Override
public void checkAccess(ThreadGroup g) {
// Allow
}
@Override
public void checkAwtEventQueueAccess() {
// Allow
}
@Override
public void checkConnect(String host, int port, Object context) {
// Allow
}
@Override
public void checkConnect(String host, int port) {
// Allow
}
@Override
public void checkCreateClassLoader() {
// Allow
}
@Override
public void checkDelete(String file) {
// Allow
}
@Override
public void checkExec(String cmd) {
// Allow
}
@Override
public void checkExit(int status) {
// Allow
}
@Override
public void checkLink(String lib) {
// Allow
}
@Override
public void checkListen(int port) {
// Allow
}
@Override
public void checkMemberAccess(Class<?> clazz, int which) {
// Allow
}
@Override
public void checkMulticast(InetAddress maddr, byte ttl) {
// Allow
}
@Override
public void checkMulticast(InetAddress maddr) {
// Allow
}
@Override
public void checkPackageAccess(String pkg) {
// Allow
}
@Override
public void checkPackageDefinition(String pkg) {
// Allow
}
@Override
public void checkPermission(Permission perm, Object context) {
// Allow
@ -162,67 +75,12 @@ public class DebugUtilTest {
// Allow
}
@Override
public void checkPrintJobAccess() {
// Allow
}
@Override
public void checkPropertiesAccess() {
// Allow
}
@Override
public void checkRead(FileDescriptor fd) {
// Allow
}
@Override
public void checkRead(String file, Object context) {
// Allow
}
@Override
public void checkRead(String file) {
// Allow
}
@Override
public void checkSecurityAccess(String target) {
// Allow
}
@Override
public void checkSetFactory() {
// Allow
}
@Override
public void checkSystemClipboardAccess() {
// Allow
}
@Override
public boolean checkTopLevelWindow(Object window) {
return true;
}
@Override
public void checkWrite(FileDescriptor fd) {
// Allow
}
@Override
public void checkWrite(String file) {
// Allow
}
});
try {
assertFalse(DebugUtil.isDebugEnabled());
} finally {
System.setSecurityManager(null);
}
}
@Before @After

101
src/test/java/org/jboss/netty/util/ThreadRenamingRunnableTest.java Normal file
View File

@ -0,0 +1,101 @@
/*
* JBoss, Home of Professional Open Source
*
* Copyright 2008, Red Hat Middleware LLC, and individual contributors
* by the @author tags. See the COPYRIGHT.txt in the distribution for a
* full listing of individual contributors.
*
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as
* published by the Free Software Foundation; either version 2.1 of
* the License, or (at your option) any later version.
*
* This software is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this software; if not, write to the Free
* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/
package org.jboss.netty.util;
import static org.easymock.EasyMock.*;
import static org.junit.Assert.*;
import java.security.Permission;
import java.util.concurrent.Executor;
import org.junit.Test;
/**
* @author The Netty Project (netty-dev@lists.jboss.org)
* @author Trustin Lee (tlee@redhat.com)
*
* @version $Rev$, $Date$
*
*/
public class ThreadRenamingRunnableTest {
@Test(expected = NullPointerException.class)
public void shouldNotAllowNullName() throws Exception {
new ThreadRenamingRunnable(createMock(Runnable.class), null);
}
@Test(expected = NullPointerException.class)
public void shouldNotAllowNullRunnable() throws Exception {
new ThreadRenamingRunnable(null, "foo");
}
@Test
public void testWithoutSecurityManager() throws Exception {
final String oldThreadName = Thread.currentThread().getName();
Executor e = ImmediateExecutor.INSTANCE;
e.execute(new ThreadRenamingRunnable(
new Runnable() {
public void run() {
assertEquals("foo", Thread.currentThread().getName());
assertFalse(oldThreadName.equals(Thread.currentThread().getName()));
}
}, "foo"));
assertEquals(oldThreadName, Thread.currentThread().getName());
}
@Test
public void testWithSecurityManager() throws Exception {
final String oldThreadName = Thread.currentThread().getName();
Executor e = ImmediateExecutor.INSTANCE;
System.setSecurityManager(new SecurityManager() {
@Override
public void checkAccess(Thread t) {
throw new SecurityException();
}
@Override
public void checkPermission(Permission perm, Object context) {
// Allow
}
@Override
public void checkPermission(Permission perm) {
// Allow
}
});
try {
e.execute(new ThreadRenamingRunnable(
new Runnable() {
public void run() {
assertEquals(oldThreadName, Thread.currentThread().getName());
}
}, "foo"));
} finally {
System.setSecurityManager(null);
assertEquals(oldThreadName, Thread.currentThread().getName());
}
}
}