andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not fail on runtime when an older version of Log4J2 is on the classpath. (#8240)

Browse Source 
Motivation:

At the moment we will just assume the correct version of log4j2 is used when we find it on the classpath. This may lead to an AbstractMethodError at runtime. We should not use log4j2 if the version is not correct.

Modifications:

Check on class loading if we can use Log4J2 or not.

Result:

Fixes #8217.
This commit is contained in:
Norman Maurer 2018-09-03 18:07:53 +02:00 committed by GitHub
parent c74b3f3a3b
commit 3eec66a974
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
common/src/main/java/io/netty/util/internal/logging/Log4J2Logger.java
View File

@ -21,14 +21,42 @@ import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.spi.ExtendedLogger;
import org.apache.logging.log4j.spi.ExtendedLoggerWrapper;
import java.security.AccessController;
import java.security.PrivilegedAction;
import static io.netty.util.internal.logging.AbstractInternalLogger.EXCEPTION_MESSAGE;
class Log4J2Logger extends ExtendedLoggerWrapper implements InternalLogger {
private static final long serialVersionUID = 5485418394879791397L;
private static final boolean VARARGS_ONLY;
static {
// Older Log4J2 versions have only log methods that takes the format + varargs. So we should not use
// Log4J2 if the version is too old.
// See https://github.com/netty/netty/issues/8217
VARARGS_ONLY = AccessController.doPrivileged(new PrivilegedAction<Boolean>() {
@Override
public Boolean run() {
try {
Logger.class.getMethod("debug", String.class, Object.class);
return false;
} catch (NoSuchMethodException ignore) {
// Log4J2 version too old.
return true;
} catch (SecurityException ignore) {
// We could not detect the version so we will use Log4J2 if its on the classpath.
return false;
}
}
});
}
Log4J2Logger(Logger logger) {
super((ExtendedLogger) logger, logger.getName(), logger.getMessageFactory());
if (VARARGS_ONLY) {
throw new UnsupportedOperationException("Log4J2 version mismatch");
}
}
@Override