andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid unnecessary IllegalStateException in ChunkedWriteHandler

Browse Source 
Motivation:
ChunkedWriteHandler can sometimes fail to write the last chunk of a ChunkedInput due to an I/O error.  Subsequently, the ChunkedInput's associated promise is marked as failure and the connection is closed.  When the connection is closed, ChunkedWriteHandler attempts to clean up its message queue and to mark their promises as success or failure.  However, because the promise of the ChunkedInput, which was consumed completely yet failed to be written, is already marked as failure, the attempt to mark it as success fails, leading a WARN level log.

Modification:
Use trySuccess() instead of setSuccess() so that the attempt to mark a ChunkedInput as success does not raise an exception even if the promise is already done.

Result:
Fixes #2249
This commit is contained in:
Trustin Lee 2014-02-20 17:14:25 -08:00
parent 97f120330b
commit 3f2d3c9f1d
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
View File

@ -338,17 +338,21 @@ public class ChunkedWriteHandler extends ChannelHandlerAdapter {
void fail(Throwable cause) {
ReferenceCountUtil.release(msg);
if (promise != null) {
promise.tryFailure(cause);
}
promise.tryFailure(cause);
}
void success() {
if (promise.isDone()) {
// No need to notify the progress or fulfill the promise because it's done already.
return;
}
if (promise instanceof ChannelProgressivePromise) {
// Now we know what the total is.
((ChannelProgressivePromise) promise).tryProgress(progress, progress);
}
promise.setSuccess();
promise.trySuccess();
}
void progress(int amount) {