andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix missed buffer leaks in SpdyFrameDecoderTest

Browse Source 
Motivation:
 Fix leaks reported during running SpdyFrameDecoderTest

Modifications:
Make sure the produced buffers of SpdyFrameDecoder and SpdyFrameDecoderTest are released

Result:

No more leak reports during run the tests.
This commit is contained in:
Norman Maurer 2014-04-16 14:01:50 +02:00
parent 2e8e7e486a
commit 40bcb17bf9
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
codec-http/src/test/java/io/netty/handler/codec/spdy/SpdyFrameDecoderTest.java
View File

@ -104,7 +104,12 @@ public class SpdyFrameDecoderTest {
@Override @Override
public void readHeaderBlock(ByteBuf headerBlock) { public void readHeaderBlock(ByteBuf headerBlock) {
delegate.readHeaderBlock(headerBlock); try {
delegate.readHeaderBlock(headerBlock);
} finally {
// release the data after we delegate it and so checked it.
headerBlock.release();
}
} }
@Override @Override
@ -430,14 +435,14 @@ public class SpdyFrameDecoderTest {
int associatedToStreamId = RANDOM.nextInt() & 0x7FFFFFFF; int associatedToStreamId = RANDOM.nextInt() & 0x7FFFFFFF;
byte priority = (byte) (RANDOM.nextInt() & 0x07); byte priority = (byte) (RANDOM.nextInt() & 0x07);
ByteBuf buf = Unpooled.buffer(SPDY_HEADER_SIZE + length + headerBlockLength); ByteBuf buf = ReferenceCountUtil.releaseLater(Unpooled.buffer(SPDY_HEADER_SIZE + length + headerBlockLength));
encodeControlFrameHeader(buf, type, flags, length + headerBlockLength); encodeControlFrameHeader(buf, type, flags, length + headerBlockLength);
buf.writeInt(streamId); buf.writeInt(streamId);
buf.writeInt(associatedToStreamId); buf.writeInt(associatedToStreamId);
buf.writeByte(priority << 5); buf.writeByte(priority << 5);
buf.writeByte(0); buf.writeByte(0);
ByteBuf headerBlock = Unpooled.buffer(headerBlockLength); ByteBuf headerBlock = ReferenceCountUtil.releaseLater(Unpooled.buffer(headerBlockLength));
for (int i = 0; i < 256; i ++) { for (int i = 0; i < 256; i ++) {
headerBlock.writeInt(RANDOM.nextInt()); headerBlock.writeInt(RANDOM.nextInt());
} }