andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FixedLengthFrameDecoder should used a optimizated initialSize

Browse Source 
when creating the cumulative ChannelBuffer. See #170
This commit is contained in:
Norman Maurer 2012-01-31 21:02:00 +01:00
parent 4d7c9b397d
commit 4116c44c77
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/main/java/org/jboss/netty/handler/codec/frame/FixedLengthFrameDecoder.java
View File

@ -16,6 +16,7 @@
package org.jboss.netty.handler.codec.frame; package org.jboss.netty.handler.codec.frame;
import org.jboss.netty.buffer.ChannelBuffer; import org.jboss.netty.buffer.ChannelBuffer;
import org.jboss.netty.buffer.ChannelBuffers;
import org.jboss.netty.channel.Channel; import org.jboss.netty.channel.Channel;
import org.jboss.netty.channel.ChannelHandlerContext; import org.jboss.netty.channel.ChannelHandlerContext;
@ -38,18 +39,28 @@ import org.jboss.netty.channel.ChannelHandlerContext;
public class FixedLengthFrameDecoder extends FrameDecoder { public class FixedLengthFrameDecoder extends FrameDecoder {
private final int frameLength; private final int frameLength;
private final boolean allocateFullBuffer;
/**
* Calls {@link #FixedLengthFrameDecoder(int, boolean)} with <code>false</code>
*/
public FixedLengthFrameDecoder(int frameLength) {
this(frameLength, false);
}
/** /**
* Creates a new instance. * Creates a new instance.
* *
* @param frameLength the length of the frame * @param frameLength the length of the frame
* @param allocateFullBuffer <code>true</code> if the cumulative {@link ChannelBuffer} should use the {@link #frameLength} as its initial size
*/ */
public FixedLengthFrameDecoder(int frameLength) { public FixedLengthFrameDecoder(int frameLength, boolean allocateFullBuffer) {
if (frameLength <= 0) { if (frameLength <= 0) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
"frameLength must be a positive integer: " + frameLength); "frameLength must be a positive integer: " + frameLength);
} }
this.frameLength = frameLength; this.frameLength = frameLength;
this.allocateFullBuffer = allocateFullBuffer;
} }
@Override @Override
@ -61,4 +72,12 @@ public class FixedLengthFrameDecoder extends FrameDecoder {
return buffer.readBytes(frameLength); return buffer.readBytes(frameLength);
} }
} }
@Override
protected ChannelBuffer createCumulationDynamicBuffer(ChannelHandlerContext ctx) {
if (allocateFullBuffer) {
return ChannelBuffers.dynamicBuffer(frameLength, ctx.getChannel().getConfig().getBufferFactory());
}
return super.createCumulationDynamicBuffer(ctx);
}
} }