andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix NoSuchElementException raised by ChannelInitializer

Browse Source 
.. again.
This commit is contained in:
Trustin Lee 2013-12-07 11:03:55 +09:00
parent 02703e8fc1
commit 4116de8360
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
transport/src/main/java/io/netty/channel/ChannelInitializer.java
View File

@ -60,23 +60,21 @@ public abstract class ChannelInitializer<C extends Channel> extends ChannelInbou
*/ */
protected abstract void initChannel(C ch) throws Exception; protected abstract void initChannel(C ch) throws Exception;
@SuppressWarnings("unchecked")
@Override @Override
public final void channelRegistered(ChannelHandlerContext ctx) @SuppressWarnings("unchecked")
throws Exception { public final void channelRegistered(ChannelHandlerContext ctx) throws Exception {
boolean removed = false; ChannelPipeline pipeline = ctx.pipeline();
boolean success = false; boolean success = false;
try { try {
initChannel((C) ctx.channel()); initChannel((C) ctx.channel());
ctx.pipeline().remove(this); pipeline.remove(this);
removed = true;
ctx.fireChannelRegistered(); ctx.fireChannelRegistered();
success = true; success = true;
} catch (Throwable t) { } catch (Throwable t) {
logger.warn("Failed to initialize a channel. Closing: " + ctx.channel(), t); logger.warn("Failed to initialize a channel. Closing: " + ctx.channel(), t);
} finally { } finally {
if (!removed) { if (pipeline.context(this) != null) {
ctx.pipeline().remove(this); pipeline.remove(this);
} }
if (!success) { if (!success) {
ctx.close(); ctx.close();