andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Trigger exceptionCaught event from the middle of the pipline (#210)

Browse Source 
.. because the previous handlers have no interest in the exceptions
raised by the next handlers.
This commit is contained in:
Trustin Lee 2012-02-29 14:02:12 -08:00
parent 40e7a5d948
commit 4158152b24
3 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java
View File

@ -169,16 +169,14 @@ public class ChunkedWriteHandler implements ChannelUpstreamHandler, ChannelDowns
}
currentEvent.getFuture().setFailure(cause);
fireExceptionCaught = true;
currentEvent = null;
}
if (fireExceptionCaught) {
if (fireNow) {
fireExceptionCaught(ctx.getChannel(), cause);
fireExceptionCaught(ctx, cause);
} else {
fireExceptionCaughtLater(ctx.getChannel(), cause);
fireExceptionCaughtLater(ctx, cause);
}
}
}
@ -227,7 +225,7 @@ public class ChunkedWriteHandler implements ChannelUpstreamHandler, ChannelDowns
if (fireNow) {
fireExceptionCaught(ctx, t);
} else {
fireExceptionCaughtLater(ctx.getChannel(), t);
fireExceptionCaughtLater(ctx, t);
}
closeInput(chunks);

2
handler/src/main/java/io/netty/handler/timeout/WriteTimeoutHandler.java
View File

@ -154,7 +154,7 @@ public class WriteTimeoutHandler extends SimpleChannelDownstreamHandler
}
protected void writeTimedOut(ChannelHandlerContext ctx) throws Exception {
Channels.fireExceptionCaughtLater(ctx.getChannel(), EXCEPTION);
Channels.fireExceptionCaughtLater(ctx, EXCEPTION);
}
private final class WriteTimeoutTask implements TimerTask {

17
transport/src/main/java/io/netty/channel/Channels.java
View File

@ -520,7 +520,22 @@ public final class Channels {
});
}
/**
* Sends a {@code "exceptionCaught"} event to the
* {@link ChannelUpstreamHandler} which is placed in the closest upstream
* from the handler associated with the specified
* {@link ChannelHandlerContext} once the io-thread runs again.
*/
public static ChannelFuture fireExceptionCaughtLater(final ChannelHandlerContext ctx, final Throwable cause) {
return ctx.getPipeline().execute(new Runnable() {
@Override
public void run() {
fireExceptionCaught(ctx, cause);
}
});
}
/**
* Sends a {@code "exceptionCaught"} event to the first
* {@link ChannelUpstreamHandler} in the {@link ChannelPipeline} of