andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Log Selector instance when Selector needs to be rebuild

Browse Source 
Motivation:

To better debug why a Selector need to be rebuild it is useful to also log the instance of the Selector.

Modifications:

Add logger instance to the log message.

Result:

More useful log message.
This commit is contained in:
Norman Maurer 2016-06-09 09:28:47 +02:00
parent 5e86325a8c
commit 418550914a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
View File

@ -715,8 +715,8 @@ public final class NioEventLoop extends SingleThreadEventLoop {
// The selector returned prematurely many times in a row. // The selector returned prematurely many times in a row.
// Rebuild the selector to work around the problem. // Rebuild the selector to work around the problem.
logger.warn( logger.warn(
"Selector.select() returned prematurely {} times in a row; rebuilding selector.", "Selector.select() returned prematurely {} times in a row; rebuilding Selector {}.",
selectCnt); selectCnt, selector);
rebuildSelector(); rebuildSelector();
selector = this.selector; selector = this.selector;
@ -732,12 +732,14 @@ public final class NioEventLoop extends SingleThreadEventLoop {
if (selectCnt > MIN_PREMATURE_SELECTOR_RETURNS) { if (selectCnt > MIN_PREMATURE_SELECTOR_RETURNS) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("Selector.select() returned prematurely {} times in a row.", selectCnt - 1); logger.debug("Selector.select() returned prematurely {} times in a row for Selector {}.",
selectCnt - 1, selector);
} }
} }
} catch (CancelledKeyException e) { } catch (CancelledKeyException e) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug(CancelledKeyException.class.getSimpleName() + " raised by a Selector - JDK bug?", e); logger.debug(CancelledKeyException.class.getSimpleName() + " raised by a Selector {} - JDK bug?",
selector, e);
} }
// Harmless exception - log anyway // Harmless exception - log anyway
} }