andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ensure SSLErrorTest also works with boringssl

Browse Source 
Motivation:

boringssl uses different messages for the ssl alerts which are all uppercase. As we try to match case as well this fails in SSLErrorTest as we expect lower-case.

This test was introduced by 9b7fb2f3620449c8cfafa62fd294cb82600f043a.

Modifications:

Ensure we first translate everything to lower-case before doing the assert.

Result:

SSLErrorTest also pass when boringssl is used.
This commit is contained in:
Norman Maurer 2016-12-07 14:06:04 +01:00
parent 8d664fa0fd
commit 41ea9fa3b6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
handler/src/test/java/io/netty/handler/ssl/SslErrorTest.java
View File

@ -58,6 +58,7 @@ import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.Date; import java.util.Date;
import java.util.List; import java.util.List;
import java.util.Locale;
@RunWith(Parameterized.class) @RunWith(Parameterized.class)
@ -238,7 +239,7 @@ public class SslErrorTest {
// at the moment as there are no different exceptions for the different alerts. // at the moment as there are no different exceptions for the different alerts.
private static void verifyException(Throwable cause, String messagePart, Promise<Void> promise) { private static void verifyException(Throwable cause, String messagePart, Promise<Void> promise) {
String message = cause.getMessage(); String message = cause.getMessage();
if (message.contains(messagePart)) { if (message.toLowerCase(Locale.UK).contains(messagePart.toLowerCase(Locale.UK))) {
promise.setSuccess(null); promise.setSuccess(null);
} else { } else {
promise.setFailure(new AssertionError("message not contains '" + messagePart + "': " + message)); promise.setFailure(new AssertionError("message not contains '" + messagePart + "': " + message));