andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DefaultChannelPipeline.replace() does not correctly replace a

Browse Source 
ChannelHandler if name is preserved. See #113
This commit is contained in:
Norman Maurer 2011-12-11 09:21:29 +01:00
parent 5c4702245c
commit 427b784c6e
2 changed files with 48 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/io/netty/channel/DefaultChannelPipeline.java
View File

@ -286,8 +286,8 @@ public class DefaultChannelPipeline implements ChannelPipeline {
if (!sameName) {
name2ctx.remove(ctx.getName());
name2ctx.put(newName, newCtx);
}
name2ctx.put(newName, newCtx);
ChannelHandlerLifeCycleException removeException = null;
ChannelHandlerLifeCycleException addException = null;

47
src/test/java/io/netty/channel/DefaultChannelPipelineTest.java Normal file
View File

@ -0,0 +1,47 @@
/*
* Copyright 2011 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.channel;
import static org.junit.Assert.*;
import org.junit.Test;
public class DefaultChannelPipelineTest {
@Test
public void testReplaceChannelHandler() {
DefaultChannelPipeline pipeline = new DefaultChannelPipeline();
SimpleChannelHandler handler1 = new SimpleChannelHandler();
pipeline.addLast("handler1", handler1);
pipeline.addLast("handler2", handler1);
pipeline.addLast("handler3", handler1);
assertTrue(pipeline.get("handler1") == handler1);
assertTrue(pipeline.get("handler2") == handler1);
assertTrue(pipeline.get("handler3") == handler1);
SimpleChannelHandler newHandler1 = new SimpleChannelHandler();
pipeline.replace("handler1", "handler1", newHandler1);
assertTrue(pipeline.get("handler1") == newHandler1);
SimpleChannelHandler newHandler3 = new SimpleChannelHandler();
pipeline.replace("handler3", "handler3", newHandler3);
assertTrue(pipeline.get("handler3") == newHandler3);
SimpleChannelHandler newHandler2 = new SimpleChannelHandler();
pipeline.replace("handler2", "handler2", newHandler2);
assertTrue(pipeline.get("handler2") == newHandler2);
}
}