From 428c11ea59f60f33d1884f6cf72e234d9cf327dc Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Tue, 15 Sep 2015 09:13:25 -0700 Subject: [PATCH] SpdyHttpHeaders are not lowercase Motivation: According to the SPDY spec https://www.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3-1#TOC-3.2.1-Request header names must be lowercase. Our predefined SPDY extension headers are not lowercase. Modifications - SpdyHttpHeaders should define header names in lower case Result: Compliant with SPDY spec, and header validation code does not detect errors for our own header names. --- .../handler/codec/spdy/SpdyHttpHeaders.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpHeaders.java index 771f0dfe70..358eb337ce 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpHeaders.java +++ b/codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHttpHeaders.java @@ -29,21 +29,21 @@ public final class SpdyHttpHeaders { */ public static final class Names { /** - * {@code "X-SPDY-Stream-ID"} + * {@code "x-spdy-stream-id"} */ - public static final String STREAM_ID = "X-SPDY-Stream-ID"; + public static final String STREAM_ID = "x-spdy-stream-id"; /** - * {@code "X-SPDY-Associated-To-Stream-ID"} + * {@code "x-spdy-associated-to-stream-id"} */ - public static final String ASSOCIATED_TO_STREAM_ID = "X-SPDY-Associated-To-Stream-ID"; + public static final String ASSOCIATED_TO_STREAM_ID = "x-spdy-associated-to-stream-id"; /** - * {@code "X-SPDY-Priority"} + * {@code "x-spdy-priority"} */ - public static final String PRIORITY = "X-SPDY-Priority"; + public static final String PRIORITY = "x-spdy-priority"; /** - * {@code "X-SPDY-Scheme"} + * {@code "x-spdy-scheme"} */ - public static final String SCHEME = "X-SPDY-Scheme"; + public static final String SCHEME = "x-spdy-scheme"; private Names() { } }