andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Return the result of the list.recycle() call (#9264)

Browse Source 
Motivation:

Resolve the issue highlighted by SpotJMHBugs that the creation of the RecyclableArrayList may be elided by the JIT since the result isn't consumed or returned.

Modifications:

Return the result of `list.recycle()` so that the list isn't elided.

Result:

The JMH benchmark shows a change in performance indicating that the prior results of this may be unsound.
This commit is contained in:
Alex Blewitt 2019-06-22 06:21:51 +01:00 committed by Norman Maurer
parent 2af769f6dc
commit 430eeee2f6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
microbench/src/main/java/io/netty/microbench/internal/RecyclableArrayListBenchmark.java
View File

@ -36,8 +36,8 @@ public class RecyclableArrayListBenchmark extends AbstractMicrobenchmark {
public int size; public int size;
@Benchmark @Benchmark
public void recycleSameThread() { public boolean recycleSameThread() {
RecyclableArrayList list = RecyclableArrayList.newInstance(size); RecyclableArrayList list = RecyclableArrayList.newInstance(size);
list.recycle(); return list.recycle();
} }
} }