andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1994] DefaultPromise.cancel() should reuse CancellationException for performance reasons

Browse Source
This commit is contained in:
Norman Maurer 2013-11-19 17:57:25 +01:00
parent d0e928db70
commit 43943c7ab1
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
common/src/main/java/io/netty/util/concurrent/DefaultPromise.java
View File

@ -16,6 +16,7 @@
package io.netty.util.concurrent; package io.netty.util.concurrent;
import io.netty.util.Signal; import io.netty.util.Signal;
import io.netty.util.internal.EmptyArrays;
import io.netty.util.internal.PlatformDependent; import io.netty.util.internal.PlatformDependent;
import io.netty.util.internal.StringUtil; import io.netty.util.internal.StringUtil;
import io.netty.util.internal.logging.InternalLogger; import io.netty.util.internal.logging.InternalLogger;
@ -39,8 +40,14 @@ public class DefaultPromise<V> extends AbstractFuture<V> implements Promise<V> {
return 0; return 0;
} }
}; };
private static final Signal SUCCESS = Signal.valueOf(DefaultPromise.class, "SUCCESS"); private static final Signal SUCCESS = Signal.valueOf(DefaultPromise.class.getName() + ".SUCCESS");
private static final Signal UNCANCELLABLE = Signal.valueOf(DefaultPromise.class, "UNCANCELLABLE"); private static final Signal UNCANCELLABLE = Signal.valueOf(DefaultPromise.class.getName() + ".UNCANCELLABLE");
private static final CauseHolder CANCELLATION_CAUSE_HOLDER = new CauseHolder(new CancellationException());
static {
CANCELLATION_CAUSE_HOLDER.cause.setStackTrace(EmptyArrays.EMPTY_STACK_TRACE);
}
private final EventExecutor executor; private final EventExecutor executor;
private volatile Object result; private volatile Object result;
@ -424,7 +431,7 @@ public class DefaultPromise<V> extends AbstractFuture<V> implements Promise<V> {
return false; return false;
} }
this.result = new CauseHolder(new CancellationException()); this.result = CANCELLATION_CAUSE_HOLDER;
if (hasWaiters()) { if (hasWaiters()) {
notifyAll(); notifyAll();
} }