Fix compilation warnings

src/main/java/org/jboss/netty/bootstrap/Bootstrap.java

@@ -358,9 +358,9 @@ public class Bootstrap implements ExternalResourceReleasable {
 
         // Does not implement OrderedMap interface.  As a last resort, try to
         // create a new instance and test if the insertion order is maintained.
-        Map newMap;
+        Map<Object, Object> newMap;
         try {
-            newMap = (Map) mapType.newInstance();
+            newMap = (Map<Object, Object>) mapType.newInstance();
         } catch (Exception e) {
             // No default constructor - cannot proceed anymore.
             return false;

src/main/java/org/jboss/netty/channel/DefaultChannelFuture.java

@@ -170,6 +170,7 @@ public class DefaultChannelFuture implements ChannelFuture {
         }
     }
 
+    @Deprecated
     public ChannelFuture rethrowIfFailed() throws Exception {
         if (!isDone()) {
             return this;

src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java

@@ -423,7 +423,9 @@ public class DefaultChannelPipeline implements ChannelPipeline {
         if (ctx == null) {
             return null;
         } else {
-            return (T) ctx.getHandler();
+            @SuppressWarnings("unchecked")
+            T handler = (T) ctx.getHandler();
+            return handler;
         }
     }
 

src/main/java/org/jboss/netty/channel/FailedChannelFuture.java

@@ -46,6 +46,7 @@ public class FailedChannelFuture extends CompleteChannelFuture {
         return false;
     }
 
+    @Deprecated
     public ChannelFuture rethrowIfFailed() throws Exception {
         if (cause instanceof Exception) {
             throw (Exception) cause;

src/main/java/org/jboss/netty/channel/StaticChannelPipeline.java

@@ -284,7 +284,9 @@ public class StaticChannelPipeline implements ChannelPipeline {
         if (ctx == null) {
             return null;
         } else {
-            return (T) ctx.getHandler();
+            @SuppressWarnings("unchecked")
+            T handler = (T) ctx.getHandler();
+            return handler;
         }
     }
 

src/main/java/org/jboss/netty/channel/SucceededChannelFuture.java

@@ -39,6 +39,7 @@ public class SucceededChannelFuture extends CompleteChannelFuture {
         return true;
     }
 
+    @Deprecated
     public ChannelFuture rethrowIfFailed() throws Exception {
         return this;
     }

src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorkerPool.java

@@ -30,8 +30,8 @@ public class NioDatagramWorkerPool extends AbstractNioWorkerPool<NioDatagramWork
     }
 
     @Override
+    @Deprecated
     protected NioDatagramWorker createWorker(Executor executor) {
         return new NioDatagramWorker(executor);
     }
-
 }

src/main/java/org/jboss/netty/channel/socket/nio/NioWorkerPool.java

@@ -40,6 +40,7 @@ public class NioWorkerPool extends AbstractNioWorkerPool<NioWorker> {
     }
 
     @Override
+    @Deprecated
     protected NioWorker createWorker(Executor executor) {
         return new NioWorker(executor, determiner);
     }

src/main/java/org/jboss/netty/handler/codec/embedder/AbstractCodecEmbedder.java

@@ -122,10 +122,12 @@ abstract class AbstractCodecEmbedder<E> implements CodecEmbedder<E> {
         return productQueue.isEmpty();
     }
 
+    @SuppressWarnings("unchecked")
     public final E poll() {
         return (E) productQueue.poll();
     }
 
+    @SuppressWarnings("unchecked")
     public final E peek() {
         return (E) productQueue.peek();
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyDataFrame.java

@@ -38,6 +38,7 @@ public class DefaultSpdyDataFrame implements SpdyDataFrame {
         setStreamId(streamId);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -46,6 +47,7 @@ public class DefaultSpdyDataFrame implements SpdyDataFrame {
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }
@@ -66,10 +68,12 @@ public class DefaultSpdyDataFrame implements SpdyDataFrame {
         this.last = last;
     }
 
+    @Deprecated
     public boolean isCompressed() {
         return compressed;
     }
 
+    @Deprecated
     public void setCompressed(boolean compressed) {
         this.compressed = compressed;
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyGoAwayFrame.java

@@ -55,6 +55,7 @@ public class DefaultSpdyGoAwayFrame implements SpdyGoAwayFrame {
         setStatus(status);
     }
 
+    @Deprecated
     public int getLastGoodStreamID() {
         return getLastGoodStreamId();
     }
@@ -63,6 +64,7 @@ public class DefaultSpdyGoAwayFrame implements SpdyGoAwayFrame {
         return lastGoodStreamId;
     }
 
+    @Deprecated
     public void setLastGoodStreamID(int lastGoodStreamId) {
         setLastGoodStreamId(lastGoodStreamId);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyHeadersFrame.java

@@ -36,6 +36,7 @@ public class DefaultSpdyHeadersFrame extends DefaultSpdyHeaderBlock
         setStreamId(streamId);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -44,6 +45,7 @@ public class DefaultSpdyHeadersFrame extends DefaultSpdyHeaderBlock
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyPingFrame.java

@@ -33,6 +33,7 @@ public class DefaultSpdyPingFrame implements SpdyPingFrame {
         setId(id);
     }
 
+    @Deprecated
     public int getID() {
         return getId();
     }
@@ -41,6 +42,7 @@ public class DefaultSpdyPingFrame implements SpdyPingFrame {
         return id;
     }
 
+    @Deprecated
     public void setID(int id) {
         setId(id);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyRstStreamFrame.java

@@ -46,6 +46,7 @@ public class DefaultSpdyRstStreamFrame implements SpdyRstStreamFrame {
         setStatus(status);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -54,6 +55,7 @@ public class DefaultSpdyRstStreamFrame implements SpdyRstStreamFrame {
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdySettingsFrame.java

@@ -29,6 +29,7 @@ public class DefaultSpdySettingsFrame implements SpdySettingsFrame {
     private boolean clear;
     private final Map<Integer, Setting> settingsMap = new TreeMap<Integer, Setting>();
 
+    @Deprecated
     public Set<Integer> getIDs() {
         return getIds();
     }
@@ -77,6 +78,7 @@ public class DefaultSpdySettingsFrame implements SpdySettingsFrame {
         }
     }
 
+    @Deprecated
     public boolean persistValue(int id) {
         return isPersistValue(id);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdySynReplyFrame.java

@@ -35,6 +35,7 @@ public class DefaultSpdySynReplyFrame extends DefaultSpdyHeaderBlock
         setStreamId(streamId);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -43,6 +44,7 @@ public class DefaultSpdySynReplyFrame extends DefaultSpdyHeaderBlock
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdySynStreamFrame.java

@@ -43,6 +43,7 @@ public class DefaultSpdySynStreamFrame extends DefaultSpdyHeaderBlock
         setPriority(priority);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -51,6 +52,7 @@ public class DefaultSpdySynStreamFrame extends DefaultSpdyHeaderBlock
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }
@@ -63,6 +65,7 @@ public class DefaultSpdySynStreamFrame extends DefaultSpdyHeaderBlock
         this.streamId = streamId;
     }
 
+    @Deprecated
     public int getAssociatedToStreamID() {
         return getAssociatedToStreamId();
     }
@@ -71,6 +74,7 @@ public class DefaultSpdySynStreamFrame extends DefaultSpdyHeaderBlock
         return associatedToStreamId;
     }
 
+    @Deprecated
     public void setAssociatedToStreamID(int associatedToStreamId) {
         setAssociatedToStreamId(associatedToStreamId);
     }

src/main/java/org/jboss/netty/handler/codec/spdy/DefaultSpdyWindowUpdateFrame.java

@@ -36,6 +36,7 @@ public class DefaultSpdyWindowUpdateFrame implements SpdyWindowUpdateFrame {
         setDeltaWindowSize(deltaWindowSize);
     }
 
+    @Deprecated
     public int getStreamID() {
         return getStreamId();
     }
@@ -44,6 +45,7 @@ public class DefaultSpdyWindowUpdateFrame implements SpdyWindowUpdateFrame {
         return streamId;
     }
 
+    @Deprecated
     public void setStreamID(int streamId) {
         setStreamId(streamId);
     }

src/main/java/org/jboss/netty/handler/execution/OrderedDownstreamThreadPoolExecutor.java

@@ -120,6 +120,7 @@ public final class OrderedDownstreamThreadPoolExecutor extends OrderedMemoryAwar
      * size in this implementation
      */
     @Override
+    @Deprecated
     public void setMaxTotalMemorySize(long maxTotalMemorySize) {
         throw new UnsupportedOperationException("Not supported by this implementation");
     }

src/main/java/org/jboss/netty/handler/queue/BlockingReadHandler.java

@@ -15,11 +15,6 @@
  */
 package org.jboss.netty.handler.queue;
 
-import java.io.IOException;
-import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.LinkedBlockingQueue;
-import java.util.concurrent.TimeUnit;
-
 import org.jboss.netty.buffer.ChannelBuffer;
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelEvent;
@@ -31,6 +26,11 @@ import org.jboss.netty.channel.MessageEvent;
 import org.jboss.netty.channel.SimpleChannelUpstreamHandler;
 import org.jboss.netty.util.internal.DeadLockProofWorker;
 
+import java.io.IOException;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.TimeUnit;
+
 /**
  * Emulates blocking read operation.  This handler stores all received messages
  * into a {@link BlockingQueue} and returns the received messages when
@@ -267,6 +267,7 @@ public class BlockingReadHandler<E> extends SimpleChannelUpstreamHandler {
         getQueue().put(e);
     }
 
+    @SuppressWarnings("unchecked")
     private E getMessage(MessageEvent e) {
         return (E) e.getMessage();
     }

src/test/java/org/jboss/netty/channel/CompleteChannelFutureTest.java

@@ -15,13 +15,13 @@
  */
 package org.jboss.netty.channel;
 
-import static org.easymock.EasyMock.*;
-import static org.junit.Assert.*;
+import org.junit.Before;
+import org.junit.Test;
 
 import java.util.concurrent.TimeUnit;
 
-import org.junit.Before;
-import org.junit.Test;
+import static org.easymock.EasyMock.*;
+import static org.junit.Assert.*;
 
 public class CompleteChannelFutureTest {
 
@@ -97,6 +97,7 @@ public class CompleteChannelFutureTest {
             throw new Error();
         }
 
+        @Deprecated
         public ChannelFuture rethrowIfFailed() throws Exception {
             throw new Error();
         }