andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Adding method to assert XML decoder framing works

Browse Source 
Motivation:

In an effort to better understand how the XmlFrameDecoder works, I consulted the tests to find a method that would reframe the inputs as per the Javadocs for that class. I couldn't find any methods that seemed to be doing it, so I wanted to add one to reinforce my understanding.

Modification:

Add a new test method to XmlFrameDecoder to assert that the reframing works as described.

Result:

New test method is added to XmlFrameDecoder
This commit is contained in:
Jeff Evans 2017-03-15 13:20:03 -05:00 committed by Norman Maurer
parent 61f53c4d07
commit 476d2aea76
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
codec/src/test/java/io/netty/handler/codec/xml/XmlFrameDecoderTest.java
View File

@ -142,6 +142,11 @@ public class XmlFrameDecoderTest {
testDecodeWithXml(input, frame1, frame2, frame3);
}
@Test
public void testFraming() {
testDecodeWithXml(Arrays.asList("<abc", ">123</a", "bc>"), "<abc>123</abc>");
}
@Test
public void testDecodeWithSampleXml() {
for (final String xmlSample : xmlSamples) {
@ -149,11 +154,13 @@ public class XmlFrameDecoderTest {
}
}
private static void testDecodeWithXml(String xml, Object... expected) {
private static void testDecodeWithXml(List<String> xmlFrames, Object... expected) {
EmbeddedChannel ch = new EmbeddedChannel(new XmlFrameDecoder(1048576));
Exception cause = null;
try {
ch.writeInbound(Unpooled.copiedBuffer(xml, CharsetUtil.UTF_8));
for (String xmlFrame : xmlFrames) {
ch.writeInbound(Unpooled.copiedBuffer(xmlFrame, CharsetUtil.UTF_8));
}
} catch (Exception e) {
cause = e;
}
@ -180,6 +187,10 @@ public class XmlFrameDecoderTest {
}
}
private static void testDecodeWithXml(String xml, Object... expected) {
testDecodeWithXml(Collections.singletonList(xml), expected);
}
private String sample(String number) throws IOException, URISyntaxException {
String path = "io/netty/handler/codec/xml/sample-" + number + ".xml";
URL url = getClass().getClassLoader().getResource(path);