andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Respect DNS port that is specified via JNDI

Browse Source 
Motivation:

JNDI allows to specify an port so we should respect it.

Modifications:

Use the specified port and if none is specifed use 53.

Result:

Correct handling of JNDI configured DNS.
This commit is contained in:
Norman Maurer 2017-07-24 13:12:53 +02:00
parent d8f4547f5c
commit 486f962252
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java
View File

@ -69,7 +69,9 @@ public final class DefaultDnsServerAddressStreamProvider implements DnsServerAdd
String[] servers = dnsUrls.split(" "); String[] servers = dnsUrls.split(" ");
for (String server : servers) { for (String server : servers) {
try { try {
defaultNameServers.add(SocketUtils.socketAddress(new URI(server).getHost(), DNS_PORT)); URI uri = new URI(server);
int port = uri.getPort();
defaultNameServers.add(SocketUtils.socketAddress(uri.getHost(), port == -1 ? DNS_PORT : port));
} catch (URISyntaxException e) { } catch (URISyntaxException e) {
logger.debug("Skipping a malformed nameserver URI: {}", server, e); logger.debug("Skipping a malformed nameserver URI: {}", server, e);
} }