andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a problem where calling Timeout.extend() generates multiple timeouts when the timeout is not expired

Browse Source
This commit is contained in:
Trustin Lee 2009-01-20 12:53:41 +00:00
parent 5b27576494
commit 48bb75b7dc
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/main/java/org/jboss/netty/handler/timeout/HashedWheelTimer.java
View File

@ -54,7 +54,7 @@ public class HashedWheelTimer implements Timer {
private static final AtomicInteger id = new AtomicInteger();
private final Worker worker = new Worker();
private final Thread workerThread;
final Thread workerThread;
final AtomicBoolean shutdown = new AtomicBoolean();
private final long roundDuration;
@ -423,10 +423,22 @@ public class HashedWheelTimer implements Timer {
lock.readLock().lock();
try {
// Reinsert the timeout to the appropriate bucket.
int oldStopIndex;
int newStopIndex;
synchronized (this) {
newStopIndex = stopIndex = schedule(this, additionalDelay);
oldStopIndex = stopIndex;
stopIndex = newStopIndex = schedule(this, additionalDelay);
}
// Remove the timeout from the old bucket if necessary.
// If this method is called from the worker thread, it means
// this timeout has been removed from the bucket already.
if (oldStopIndex != newStopIndex &&
Thread.currentThread() != workerThread) {
wheel[oldStopIndex].remove(this);
}
// And add to the new bucket. If added already, that's fine.
wheel[newStopIndex].add(this);
} finally {
extensionCount ++;
@ -514,4 +526,16 @@ public class HashedWheelTimer implements Timer {
return buf.append(')').toString();
}
}
public static void main(String[] args) throws Exception {
Timer timer = new HashedWheelTimer();
for (int i = 0; i < 100000; i ++) {
timer.newTimeout(new TimerTask() {
public void run(Timeout timeout) throws Exception {
// Extend another second.
timeout.extend();
}
}, 1000, TimeUnit.MILLISECONDS);
}
}
}