From 4b9125f9610ad7a108dc16f5e41da0ad8a044080 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Wed, 11 Jul 2018 10:18:18 +0100 Subject: [PATCH] Correctly release message in MemcacheClientHandler that is used in the memcache example. (#8119) Motivation: MemcacheClientHandler.channelRead(...) need to release the frame after it prints out its content to not introduce a memory leak. Modifications: Call release() on the frame. Result: Example has no leak any more. --- .../io/netty/example/memcache/binary/MemcacheClientHandler.java | 1 + 1 file changed, 1 insertion(+) diff --git a/example/src/main/java/io/netty/example/memcache/binary/MemcacheClientHandler.java b/example/src/main/java/io/netty/example/memcache/binary/MemcacheClientHandler.java index c2ee142f7b..1864ad33c2 100644 --- a/example/src/main/java/io/netty/example/memcache/binary/MemcacheClientHandler.java +++ b/example/src/main/java/io/netty/example/memcache/binary/MemcacheClientHandler.java @@ -69,6 +69,7 @@ public class MemcacheClientHandler extends ChannelDuplexHandler { public void channelRead(ChannelHandlerContext ctx, Object msg) { FullBinaryMemcacheResponse res = (FullBinaryMemcacheResponse) msg; System.out.println(res.content().toString(CharsetUtil.UTF_8)); + res.release(); } @Override