Deprecate getName() methods of the codec classes in SOCKS codec package

Motivation:

We do not provide such methods that provide the default name of the handlers.  It had to be noticed and removed during the review phase, but we failed to do so.

Modifications:

Deprecate getName() static methods in the SOCKS codec classes

Result:

Getting closer to other codecs in API design.
This commit is contained in:
Trustin Lee 2014-05-23 17:24:03 +09:00
parent 2ff4e458c1
commit 4ce1274497
7 changed files with 28 additions and 0 deletions

View File

@ -28,6 +28,10 @@ import org.jboss.netty.util.CharsetUtil;
public class SocksAuthRequestDecoder extends ReplayingDecoder<SocksAuthRequestDecoder.State> { public class SocksAuthRequestDecoder extends ReplayingDecoder<SocksAuthRequestDecoder.State> {
private static final String name = "SOCKS_AUTH_REQUEST_DECODER"; private static final String name = "SOCKS_AUTH_REQUEST_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -27,6 +27,10 @@ import org.jboss.netty.handler.codec.replay.ReplayingDecoder;
public class SocksAuthResponseDecoder extends ReplayingDecoder<SocksAuthResponseDecoder.State> { public class SocksAuthResponseDecoder extends ReplayingDecoder<SocksAuthResponseDecoder.State> {
private static final String name = "SOCKS_AUTH_RESPONSE_DECODER"; private static final String name = "SOCKS_AUTH_RESPONSE_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -28,6 +28,10 @@ import org.jboss.netty.util.CharsetUtil;
public class SocksCmdRequestDecoder extends ReplayingDecoder<SocksCmdRequestDecoder.State> { public class SocksCmdRequestDecoder extends ReplayingDecoder<SocksCmdRequestDecoder.State> {
private static final String name = "SOCKS_CMD_REQUEST_DECODER"; private static final String name = "SOCKS_CMD_REQUEST_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -28,6 +28,10 @@ import org.jboss.netty.util.CharsetUtil;
public class SocksCmdResponseDecoder extends ReplayingDecoder<SocksCmdResponseDecoder.State> { public class SocksCmdResponseDecoder extends ReplayingDecoder<SocksCmdResponseDecoder.State> {
private static final String name = "SOCKS_CMD_RESPONSE_DECODER"; private static final String name = "SOCKS_CMD_RESPONSE_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -30,6 +30,10 @@ import java.util.List;
public class SocksInitRequestDecoder extends ReplayingDecoder<SocksInitRequestDecoder.State> { public class SocksInitRequestDecoder extends ReplayingDecoder<SocksInitRequestDecoder.State> {
private static final String name = "SOCKS_INIT_REQUEST_DECODER"; private static final String name = "SOCKS_INIT_REQUEST_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -27,6 +27,10 @@ import org.jboss.netty.handler.codec.replay.ReplayingDecoder;
public class SocksInitResponseDecoder extends ReplayingDecoder<SocksInitResponseDecoder.State> { public class SocksInitResponseDecoder extends ReplayingDecoder<SocksInitResponseDecoder.State> {
private static final String name = "SOCKS_INIT_RESPONSE_DECODER"; private static final String name = "SOCKS_INIT_RESPONSE_DECODER";
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }

View File

@ -33,6 +33,10 @@ public class SocksMessageEncoder extends OneToOneEncoder {
private static final String name = "SOCKS_MESSAGE_ENCODER"; private static final String name = "SOCKS_MESSAGE_ENCODER";
private static final int DEFAULT_ENCODER_BUFFER_SIZE = 1024; private static final int DEFAULT_ENCODER_BUFFER_SIZE = 1024;
/**
* @deprecated Will be removed at the next minor version bump.
*/
@Deprecated
public static String getName() { public static String getName() {
return name; return name;
} }