From 4d1458604ab3d378192c6240dd12ea85d1223838 Mon Sep 17 00:00:00 2001
From: Norman Maurer <norman_maurer@apple.com>
Date: Wed, 26 Sep 2018 19:59:00 +0200
Subject: [PATCH] Fix leak in SniClientTest. (#8324)

Motivation:

We need to release the ReferenceCountedSslContext to eliminate resource leaks.

Reported in https://garage.netty.io/teamcity/viewLog.html?buildId=33353&buildTypeId=netty_build_oraclejdk8&tab=buildLog#_focus=157264.

Modifications:

Call release on the SslContext instances.

Result:

No more leaks in tests.
---
 .../io/netty/handler/ssl/SniClientTest.java   | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java b/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java
index 238594bbf4..7cb473150f 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SniClientTest.java
@@ -28,6 +28,8 @@ import io.netty.channel.local.LocalServerChannel;
 import io.netty.handler.ssl.util.InsecureTrustManagerFactory;
 import io.netty.handler.ssl.util.SelfSignedCertificate;
 import io.netty.util.Mapping;
+import io.netty.util.ReferenceCountUtil;
+import io.netty.util.ReferenceCounted;
 import io.netty.util.concurrent.Promise;
 import io.netty.util.internal.PlatformDependent;
 import org.junit.Assert;
@@ -95,12 +97,13 @@ public class SniClientTest {
         String sniHostName = "sni.netty.io";
         LocalAddress address = new LocalAddress("test");
         EventLoopGroup group = new DefaultEventLoopGroup(1);
+        SelfSignedCertificate cert = new SelfSignedCertificate();
+        SslContext sslServerContext = null;
+        SslContext sslClientContext = null;
+
         Channel sc = null;
         Channel cc = null;
         try {
-            SelfSignedCertificate cert = new SelfSignedCertificate();
-
-            final SslContext sslServerContext;
             if ((sslServerProvider == SslProvider.OPENSSL || sslServerProvider == SslProvider.OPENSSL_REFCNT)
                 && !OpenSsl.useKeyManagerFactory()) {
                 sslServerContext = SslContextBuilder.forServer(cert.certificate(), cert.privateKey())
@@ -118,6 +121,7 @@ public class SniClientTest {
                                                    .build();
             }
 
+            final SslContext finalContext = sslServerContext;
             final Promise<String> promise = group.next().newPromise();
             ServerBootstrap sb = new ServerBootstrap();
             sc = sb.group(group).channel(LocalServerChannel.class).childHandler(new ChannelInitializer<Channel>() {
@@ -127,7 +131,7 @@ public class SniClientTest {
                         @Override
                         public SslContext map(String input) {
                             promise.setSuccess(input);
-                            return sslServerContext;
+                            return finalContext;
                         }
                     }));
                 }
@@ -136,12 +140,12 @@ public class SniClientTest {
             TrustManagerFactory tmf = PlatformDependent.javaVersion() >= 8 ?
                     SniClientJava8TestUtil.newSniX509TrustmanagerFactory(sniHostName) :
                     InsecureTrustManagerFactory.INSTANCE;
-            SslContext sslContext = SslContextBuilder.forClient().trustManager(tmf)
+            sslClientContext = SslContextBuilder.forClient().trustManager(tmf)
                                                      .sslProvider(sslClientProvider).build();
             Bootstrap cb = new Bootstrap();
 
             SslHandler handler = new SslHandler(
-                    sslContext.newEngine(ByteBufAllocator.DEFAULT, sniHostName, -1));
+                    sslClientContext.newEngine(ByteBufAllocator.DEFAULT, sniHostName, -1));
             cc = cb.group(group).channel(LocalChannel.class).handler(handler)
                     .connect(address).syncUninterruptibly().channel();
             Assert.assertEquals(sniHostName, promise.syncUninterruptibly().getNow());
@@ -160,6 +164,11 @@ public class SniClientTest {
             if (sc != null) {
                 sc.close().syncUninterruptibly();
             }
+            ReferenceCountUtil.release(sslServerContext);
+            ReferenceCountUtil.release(sslClientContext);
+
+            cert.delete();
+
             group.shutdownGracefully();
         }
     }