andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix incorrect port range check

Browse Source 
Motivation:

In the Internet Protocol, the valid port number range is from 1 to 65535
(inclusive on the both side.)  However, SocksCmdRequest refuses to
construct itself when the port number 65535 is specified.

Modification:

Do not raise an exception when the specified port number is 65535.

Result:

Fixes #2428
This commit is contained in:
Trustin Lee 2014-04-29 17:55:13 +09:00
parent bf5c928796
commit 4d271ddefe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdRequest.java
View File

@ -63,7 +63,7 @@ public final class SocksCmdRequest extends SocksRequest {
case UNKNOWN: case UNKNOWN:
break; break;
} }
if (port < 0 && port >= 65535) { if (port < 0 && port >= 65536) {
throw new IllegalArgumentException(port + " is not in bounds 0 < x < 65536"); throw new IllegalArgumentException(port + " is not in bounds 0 < x < 65536");
} }
this.cmdType = cmdType; this.cmdType = cmdType;